From 3ad0b3622cf92989584097787323f00bc7a36c48 Mon Sep 17 00:00:00 2001 From: Petr Pisar Date: Thu, 12 May 2011 13:13:56 +0200 Subject: Make global symbols static as possible There are some calls (e.g. getpwnam(3)) that can lead to dlopening other libraries that could jump to symbol with name clashing to one of global quota symbols. (e.g. Name server switch plug-in nss_db calls dirname(3) that's already defined in edquota.c and tht can cause segmentation fault.) Although it's not possible to solve all these problems, making as much as possible global objects and functions static is the best thing we can do to avoid name space polution. Signed-off-by: Jan Kara --- rquota_svc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'rquota_svc.c') diff --git a/rquota_svc.c b/rquota_svc.c index 7ed8524..17a92f4 100644 --- a/rquota_svc.c +++ b/rquota_svc.c @@ -169,7 +169,7 @@ static void parse_options(int argc, char **argv) * good_client checks if an quota client should be allowed to * execute the requested rpc call. */ -int good_client(struct sockaddr_in *addr, ulong rq_proc) +static int good_client(struct sockaddr_in *addr, ulong rq_proc) { #ifdef HOSTS_ACCESS struct request_info req; -- cgit v1.2.1