diff options
author | Tobias Hieta <tobias@hieta.se> | 2023-04-14 09:44:35 +0200 |
---|---|---|
committer | Tobias Hieta <tobias@hieta.se> | 2023-04-17 16:26:14 +0200 |
commit | 70e4662aa4993f69a471bc2e274e7002fad74a02 (patch) | |
tree | d623007767ca1c7e1520954bbf9470b5d0c4c6a5 | |
parent | bf80902fdd43eed5b7a4c401bccc0a06ceac582c (diff) | |
download | llvm-70e4662aa4993f69a471bc2e274e7002fad74a02.tar.gz |
Revert "[clang-format] Handle object instansiation in if-statements"
This reverts commit 70de684d44135b4025d92b2b36ad387cf5ab8b5a.
This causes a regression as described in #61785
(cherry picked from commit 104cd749f5cca609a79303c0dad22bc041b5448a)
-rw-r--r-- | clang/lib/Format/TokenAnnotator.cpp | 9 | ||||
-rw-r--r-- | clang/unittests/Format/TokenAnnotatorTest.cpp | 12 |
2 files changed, 1 insertions, 20 deletions
diff --git a/clang/lib/Format/TokenAnnotator.cpp b/clang/lib/Format/TokenAnnotator.cpp index ca651eaa9440..464594bf7488 100644 --- a/clang/lib/Format/TokenAnnotator.cpp +++ b/clang/lib/Format/TokenAnnotator.cpp @@ -399,8 +399,7 @@ private: FormatToken *Next = CurrentToken->Next; if (PrevPrev && PrevPrev->is(tok::identifier) && Prev->isOneOf(tok::star, tok::amp, tok::ampamp) && - CurrentToken->is(tok::identifier) && - !Next->isOneOf(tok::equal, tok::l_brace)) { + CurrentToken->is(tok::identifier) && Next->isNot(tok::equal)) { Prev->setType(TT_BinaryOperator); LookForDecls = false; } @@ -2399,12 +2398,6 @@ private: return TT_PointerOrReference; } - // if (Class* obj { function() }) - if (PrevToken->Tok.isAnyIdentifier() && NextToken->Tok.isAnyIdentifier() && - NextToken->Next && NextToken->Next->is(tok::l_brace)) { - return TT_PointerOrReference; - } - if (PrevToken->endsSequence(tok::r_square, tok::l_square, tok::kw_delete)) return TT_UnaryOperator; diff --git a/clang/unittests/Format/TokenAnnotatorTest.cpp b/clang/unittests/Format/TokenAnnotatorTest.cpp index e44d666206b4..8b41a9f1ca22 100644 --- a/clang/unittests/Format/TokenAnnotatorTest.cpp +++ b/clang/unittests/Format/TokenAnnotatorTest.cpp @@ -146,18 +146,6 @@ TEST_F(TokenAnnotatorTest, UnderstandsUsesOfStarAndAmp) { EXPECT_TOKEN(Tokens[7], tok::star, TT_UnaryOperator); EXPECT_TOKEN(Tokens[12], tok::star, TT_PointerOrReference); - Tokens = annotate("if (Foo * Bar / Test)"); - ASSERT_EQ(Tokens.size(), 9u) << Tokens; - EXPECT_TOKEN(Tokens[3], tok::star, TT_BinaryOperator); - - Tokens = annotate("if (Class* obj {getObj()})"); - ASSERT_EQ(Tokens.size(), 12u) << Tokens; - EXPECT_TOKEN(Tokens[3], tok::star, TT_PointerOrReference); - - Tokens = annotate("if (Foo* Bar = getObj())"); - ASSERT_EQ(Tokens.size(), 11u) << Tokens; - EXPECT_TOKEN(Tokens[3], tok::star, TT_PointerOrReference); - Tokens = annotate("int f3() { return sizeof(Foo&); }"); ASSERT_EQ(Tokens.size(), 14u) << Tokens; EXPECT_TOKEN(Tokens[9], tok::amp, TT_PointerOrReference); |