diff options
| author | Ben Langmuir <blangmuir@apple.com> | 2021-12-10 11:49:04 -0800 |
|---|---|---|
| committer | Ben Langmuir <blangmuir@apple.com> | 2021-12-14 09:59:07 -0800 |
| commit | 71e97ad35b2abcc89cc8ff471a3eb404120cf208 (patch) | |
| tree | df432ba34bb1da6cbbafb105a14d5c9cfab7fcb0 | |
| parent | d4d76409d13e8fe685b5cd6e2d7584554c2a9c7d (diff) | |
| download | llvm-71e97ad35b2abcc89cc8ff471a3eb404120cf208.tar.gz | |
Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib
When building LLVM static libraries, we should not make symbols more
visible than CMAKE_CXX_VISIBILITY_PRESET, since the goal may be to have
a purely hidden llvm embedded in another library. Instead, we only
define LLVM_EXTERNAL_VISIBILITY for the dynamic library build (when
LLVM_BUILD_LLVM_DYLIB=YES).
Differential Revision: https://reviews.llvm.org/D113610
| -rw-r--r-- | llvm/include/llvm/Config/llvm-config.h.cmake | 3 | ||||
| -rw-r--r-- | llvm/include/llvm/Support/Compiler.h | 10 |
2 files changed, 10 insertions, 3 deletions
diff --git a/llvm/include/llvm/Config/llvm-config.h.cmake b/llvm/include/llvm/Config/llvm-config.h.cmake index 4493bb65d444..a182f835c0f2 100644 --- a/llvm/include/llvm/Config/llvm-config.h.cmake +++ b/llvm/include/llvm/Config/llvm-config.h.cmake @@ -103,4 +103,7 @@ /* Define if the xar_open() function is supported on this platform. */ #cmakedefine LLVM_HAVE_LIBXAR ${LLVM_HAVE_LIBXAR} +/* Define if building libLLVM shared library */ +#cmakedefine LLVM_BUILD_LLVM_DYLIB + #endif diff --git a/llvm/include/llvm/Support/Compiler.h b/llvm/include/llvm/Support/Compiler.h index c5318137ed3d..abb0dab16cbc 100644 --- a/llvm/include/llvm/Support/Compiler.h +++ b/llvm/include/llvm/Support/Compiler.h @@ -121,12 +121,16 @@ /// On PE/COFF targets, library visibility is the default, so this isn't needed. /// /// LLVM_EXTERNAL_VISIBILITY - classes, functions, and variables marked with -/// this attribute will be made public and visible outside of any shared library -/// they are linked in to. +/// this attribute will be made public and visible outside the libLLVM dynamic +/// library. #if __has_attribute(visibility) && !defined(__MINGW32__) && \ !defined(__CYGWIN__) && !defined(_WIN32) #define LLVM_LIBRARY_VISIBILITY __attribute__ ((visibility("hidden"))) -#define LLVM_EXTERNAL_VISIBILITY __attribute__ ((visibility("default"))) +#if defined(LLVM_BUILD_LLVM_DYLIB) +#define LLVM_EXTERNAL_VISIBILITY __attribute__((visibility("default"))) +#else +#define LLVM_EXTERNAL_VISIBILITY +#endif #else #define LLVM_LIBRARY_VISIBILITY #define LLVM_EXTERNAL_VISIBILITY |