diff options
author | Tanya Lattner <tonic@nondot.org> | 2009-02-14 01:04:03 +0000 |
---|---|---|
committer | Tanya Lattner <tonic@nondot.org> | 2009-02-14 01:04:03 +0000 |
commit | 031126cbe472ae83fed7d88927ee78d364be88e6 (patch) | |
tree | 978aee6de5c04d1688d63b2cd28e9c179764be2a | |
parent | 904dbdb2d2f78234a3443c6bbd69b5255cfd698f (diff) | |
download | llvm-031126cbe472ae83fed7d88927ee78d364be88e6.tar.gz |
Merge 64364 from mainline.
Fix a nasty bug (PR3550) where the inline pass could incorrectly mark
calls with the tail marker when inlining them through an invoke. Patch,
testcase, and perfect analysis by Jay Foad!
llvm-svn: 64520
-rw-r--r-- | llvm/lib/Transforms/Utils/InlineFunction.cpp | 4 | ||||
-rw-r--r-- | llvm/test/Transforms/Inline/inline-invoke-tail.ll | 35 |
2 files changed, 37 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/Utils/InlineFunction.cpp b/llvm/lib/Transforms/Utils/InlineFunction.cpp index 758b97ea9154..a96c7ceaa8ed 100644 --- a/llvm/lib/Transforms/Utils/InlineFunction.cpp +++ b/llvm/lib/Transforms/Utils/InlineFunction.cpp @@ -203,10 +203,10 @@ bool llvm::InlineFunction(CallSite CS, CallGraph *CG, const TargetData *TD) { CalledFunc->getFunctionType()->isVarArg()) return false; - // If the call to the callee is a non-tail call, we must clear the 'tail' + // If the call to the callee is not a tail call, we must clear the 'tail' // flags on any calls that we inline. bool MustClearTailCallFlags = - isa<CallInst>(TheCall) && !cast<CallInst>(TheCall)->isTailCall(); + !(isa<CallInst>(TheCall) && cast<CallInst>(TheCall)->isTailCall()); // If the call to the callee cannot throw, set the 'nounwind' flag on any // calls that we inline. diff --git a/llvm/test/Transforms/Inline/inline-invoke-tail.ll b/llvm/test/Transforms/Inline/inline-invoke-tail.ll new file mode 100644 index 000000000000..53f755e44564 --- /dev/null +++ b/llvm/test/Transforms/Inline/inline-invoke-tail.ll @@ -0,0 +1,35 @@ +; RUN: llvm-as < %s | opt -inline | llvm-dis | not grep {tail call void @llvm.memcpy.i32} +; PR3550 + +define internal void @foo(i32* %p, i32* %q) { + %pp = bitcast i32* %p to i8* + %qq = bitcast i32* %q to i8* + tail call void @llvm.memcpy.i32(i8* %pp, i8* %qq, i32 4, i32 1) + ret void +} + +declare void @llvm.memcpy.i32(i8* nocapture, i8* nocapture, i32, i32) nounwind + +define i32 @main() { + %a = alloca i32 ; <i32*> [#uses=3] + %b = alloca i32 ; <i32*> [#uses=2] + store i32 1, i32* %a, align 4 + store i32 0, i32* %b, align 4 + invoke void @foo(i32* %a, i32* %b) + to label %invcont unwind label %lpad + +invcont: + %retval = load i32* %a, align 4 + ret i32 %retval + +lpad: + %eh_ptr = call i8* @llvm.eh.exception() + %eh_select = call i32 (i8*, i8*, ...)* @llvm.eh.selector.i32(i8* %eh_ptr, i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*), i8* null) + unreachable +} + +declare i8* @llvm.eh.exception() nounwind + +declare i32 @llvm.eh.selector.i32(i8*, i8*, ...) nounwind + +declare i32 @__gxx_personality_v0(...) |