diff options
author | Tanya Lattner <tonic@nondot.org> | 2009-10-12 16:46:55 +0000 |
---|---|---|
committer | Tanya Lattner <tonic@nondot.org> | 2009-10-12 16:46:55 +0000 |
commit | 901cb73cc5640a6405e7d7f8f5d4b8627482a04f (patch) | |
tree | 3fcfdbf3854cae9a2a5c0ea29a5ceeb63075d6a2 | |
parent | f97bad7a6f86eb2c281e536f6df98a677165c997 (diff) | |
download | llvm-901cb73cc5640a6405e7d7f8f5d4b8627482a04f.tar.gz |
Merge 83417 from mainline.
r83391 was completely broken since Twines keep references to their inputs, and
some of the inputs were temporaries. Here's a real fix for the miscompilation.
Thanks to sabre for pointing out the problem.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_26@83859 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Support/Triple.cpp | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/lib/Support/Triple.cpp b/lib/Support/Triple.cpp index 6fde0c9eabda..eb3d9ca2673b 100644 --- a/lib/Support/Triple.cpp +++ b/lib/Support/Triple.cpp @@ -9,6 +9,7 @@ #include "llvm/ADT/Triple.h" +#include "llvm/ADT/SmallString.h" #include "llvm/ADT/Twine.h" #include <cassert> #include <cstring> @@ -326,10 +327,14 @@ void Triple::setOS(OSType Kind) { } void Triple::setArchName(const StringRef &Str) { - // Work around a miscompilation bug in gcc 4.0.3. - Twine a = getVendorName() + "-" + getOSAndEnvironmentName(); - Twine b = Str + "-" + a; - setTriple(b); + // Work around a miscompilation bug for Twines in gcc 4.0.3. + SmallString<64> Triple; + Triple += Str; + Triple += "-"; + Triple += getVendorName(); + Triple += "-"; + Triple += getOSAndEnvironmentName(); + setTriple(Triple.str()); } void Triple::setVendorName(const StringRef &Str) { |