diff options
author | Filipe Cabecinhas <me@filcab.net> | 2015-06-06 20:44:53 +0000 |
---|---|---|
committer | Filipe Cabecinhas <me@filcab.net> | 2015-06-06 20:44:53 +0000 |
commit | ce986b6bc0f5119d9fdf928cc8ab80e5e6bd165f (patch) | |
tree | 3c6e2c51112e5ab683ea9ee5d472cf633f655904 /lib/Bitcode | |
parent | 2ca8f0f5d6b258c53bcf781124e01d264cd8ff1a (diff) | |
download | llvm-ce986b6bc0f5119d9fdf928cc8ab80e5e6bd165f.tar.gz |
Use early return idiom. NFC
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@239228 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Bitcode')
-rw-r--r-- | lib/Bitcode/Reader/BitcodeReader.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/lib/Bitcode/Reader/BitcodeReader.cpp b/lib/Bitcode/Reader/BitcodeReader.cpp index 75b3b9fd73c5..056d87beef15 100644 --- a/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/lib/Bitcode/Reader/BitcodeReader.cpp @@ -2065,13 +2065,13 @@ std::error_code BitcodeReader::ResolveGlobalAndAliasInits() { if (ValID >= ValueList.size()) { AliasInits.push_back(AliasInitWorklist.back()); } else { - if (Constant *C = dyn_cast_or_null<Constant>(ValueList[ValID])) { - GlobalAlias *Alias = AliasInitWorklist.back().first; - if (C->getType() != Alias->getType()) - return Error("Alias and aliasee types don't match"); - Alias->setAliasee(C); - } else + Constant *C = dyn_cast_or_null<Constant>(ValueList[ValID]); + if (!C) return Error("Expected a constant"); + GlobalAlias *Alias = AliasInitWorklist.back().first; + if (C->getType() != Alias->getType()) + return Error("Alias and aliasee types don't match"); + Alias->setAliasee(C); } AliasInitWorklist.pop_back(); } |