diff options
| author | Reid Kleckner <reid@kleckner.net> | 2014-11-13 23:32:52 +0000 |
|---|---|---|
| committer | Reid Kleckner <reid@kleckner.net> | 2014-11-13 23:32:52 +0000 |
| commit | 016f651f8d47815498a93d38db48ff9cdc7fc306 (patch) | |
| tree | 64b91737ab24bf5eee46d29e095610b4afe9d259 /test/ExecutionEngine | |
| parent | 4dc6aa2c1737cf77b5621dc00920cb7165470682 (diff) | |
| download | llvm-016f651f8d47815498a93d38db48ff9cdc7fc306.tar.gz | |
Fix symbol resolution of floating point libc builtins in MCJIT
Fix for LLI failure on Windows\X86: http://llvm.org/PR5053
LLI.exe crashes on Windows\X86 when single precession floating point
intrinsics like the following are used: acos, asin, atan, atan2, ceil,
copysign, cos, cosh, exp, floor, fmin, fmax, fmod, log, pow, sin, sinh,
sqrt, tan, tanh
The above intrinsics are defined as inline-expansions in math.h, and are
not exported by msvcr120.dll (Win32 API GetProcAddress returns null).
For an FREM instruction, the JIT compiler generates a call to a stub for
the fmodf() intrinsic, and adds a relocation to fixup at load time. The
loader searches the libraries for the function, but fails because the
symbol is not exported. So, the call target remains NULL and the
execution crashes.
Since the math functions are loaded at JIT/runtime, the JIT can patch
CALL instruction directly instead of the searching the libraries'
exported symbols. However, this fix caused build failures due to
unresolved symbols like _fmodf at link time.
Therefore, the current fix defines helper functions in the Runtime
link/load library to perform the above operations. The address of these
helper functions are used to patch up the CALL instruction at load time.
Reviewers: lhames, rnk
Reviewed By: rnk
Differential Revision: http://reviews.llvm.org/D5387
Patch by Swaroop Sridhar!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@221947 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/ExecutionEngine')
| -rw-r--r-- | test/ExecutionEngine/frem.ll | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/test/ExecutionEngine/frem.ll b/test/ExecutionEngine/frem.ll new file mode 100644 index 000000000000..7e0b6060f6fe --- /dev/null +++ b/test/ExecutionEngine/frem.ll @@ -0,0 +1,20 @@ +; LLI.exe used to crash on Windows\X86 when certain single precession +; floating point intrinsics (defined as macros) are used. +; This unit test guards against the failure. +; +; RUN: %lli %s | FileCheck %s + +@flt = internal global float 12.0e+0 +@str = internal constant [18 x i8] c"Double value: %f\0A\00" + +declare i32 @printf(i8* nocapture, ...) nounwind + +define i32 @main() { + %flt = load float* @flt + %float2 = frem float %flt, 5.0 + %double1 = fpext float %float2 to double + call i32 (i8*, ...)* @printf(i8* getelementptr ([18 x i8]* @str, i32 0, i64 0), double %double1) + ret i32 0 +} + +; CHECK: Double value: 2.0 |