Fix obvious decoding logic bug in decode_sdr_sdram().

git-svn-id: http://lm-sensors.org/svn/lm-sensors/trunk@5565 7894878c-1315-0410-8ee3-d5d059ff63e0

2 files changed, 4 insertions, 3 deletions

diff --git a/CHANGES b/CHANGES
index b36da1d1..05f84478 100644
--- a/CHANGES
+++ b/CHANGES
@@ -18,6 +18,7 @@ SVN-HEAD
   Module lm90: Don't spam the kernel log (2.6 backport)
   Module max1619: Use inline functions instead of macros (2.6 backport)
   Program decode-dimms.pl: Only export the ceil function from POSIX 
+                           Fix decoding of SDR SDRAM bytes 12-14
   Program pwmconfig: Fix MINSTOP and MINSTART test functions (#2340)
                      Change default for MINTEMP from 0 to 20 degrees C
   Program sensord: Add it8720 support
diff --git a/prog/eeprom/decode-dimms.pl b/prog/eeprom/decode-dimms.pl
index 0808f091..f98ba482 100755
--- a/prog/eeprom/decode-dimms.pl
+++ b/prog/eeprom/decode-dimms.pl
@@ -532,7 +532,7 @@ sub decode_sdr_sdram($)
 	else { printl $l, "Undefined!"; }
 
 	$l = "Refresh Type";
-	if ($bytes->[12] > 126) { printl $l, "Self Refreshing"; }
+	if ($bytes->[12] & 0x80) { printl $l, "Self Refreshing"; }
 	else { printl $l, "Not Self Refreshing"; }
 
 	$l = "Refresh Rate";
@@ -546,7 +546,7 @@ sub decode_sdr_sdram($)
 	else { printl $l, "Undefined!"; }
 
 	$l = "Primary SDRAM Component Bank Config";
-	if ($bytes->[13] > 126) { printl $l, "Bank2 = 2 x Bank1"; }
+	if ($bytes->[13] & 0x80) { printl $l, "Bank2 = 2 x Bank1"; }
 	else { printl $l, "No Bank2 OR Bank2 = Bank1 width"; }
 
 	$l = "Primary SDRAM Component Widths";
@@ -555,7 +555,7 @@ sub decode_sdr_sdram($)
 	else { printl $l, $temp; }
 
 	$l = "Error Checking SDRAM Component Bank Config";
-	if ($bytes->[14] > 126) { printl $l, "Bank2 = 2 x Bank1"; }
+	if ($bytes->[14] & 0x80) { printl $l, "Bank2 = 2 x Bank1"; }
 	else { printl $l, "No Bank2 OR Bank2 = Bank1 width"; }
 
 	$l = "Error Checking SDRAM Component Widths";