diff options
author | Roberto Ierusalimschy <roberto@inf.puc-rio.br> | 2021-02-09 14:00:05 -0300 |
---|---|---|
committer | Roberto Ierusalimschy <roberto@inf.puc-rio.br> | 2021-02-09 14:00:05 -0300 |
commit | 4e47f81188d37e29027158b76271d02a781242e2 (patch) | |
tree | c360912d1901acf8371390cc1f716278e5d91bb4 /lfunc.c | |
parent | c63e5d212bc5dec1b1c749e3f07b42cd83081826 (diff) | |
download | lua-github-4e47f81188d37e29027158b76271d02a781242e2.tar.gz |
New implementation for to-be-closed variables
To-be-closed variables are linked in their own list, embedded into the
stack elements. (Due to alignment, this information does not change
the size of the stack elements in most architectures.) This new list
does not produce garbage and avoids memory errors when creating tbc
variables.
Diffstat (limited to 'lfunc.c')
-rw-r--r-- | lfunc.c | 66 |
1 files changed, 34 insertions, 32 deletions
@@ -120,11 +120,11 @@ static void callclosemethod (lua_State *L, TValue *obj, TValue *err, int yy) { /* -** Check whether 'obj' has a close metamethod and raise an error -** if not. +** Check whether object at given level has a close metamethod and raise +** an error if not. */ -static void checkclosemth (lua_State *L, StkId level, const TValue *obj) { - const TValue *tm = luaT_gettmbyobj(L, obj, TM_CLOSE); +static void checkclosemth (lua_State *L, StkId level) { + const TValue *tm = luaT_gettmbyobj(L, s2v(level), TM_CLOSE); if (ttisnil(tm)) { /* no metamethod? */ int idx = cast_int(level - L->ci->func); /* variable index */ const char *vname = luaG_findlocal(L, L->ci, idx, NULL); @@ -155,20 +155,21 @@ static void prepcallclosemth (lua_State *L, StkId level, int status, int yy) { /* -** Create a to-be-closed upvalue. If there is a memory allocation error, -** 'ptbc' keeps the object so it can be closed as soon as possible. -** (Since memory errors have no handler, that will happen before any -** stack reallocation.) +** Insert a variable in the list of to-be-closed variables. */ void luaF_newtbcupval (lua_State *L, StkId level) { - TValue *obj = s2v(level); - lua_assert(L->openupval == NULL || uplevel(L->openupval) < level); - if (!l_isfalse(obj)) { /* false doesn't need to be closed */ - checkclosemth(L, level, obj); - L->ptbc = level; /* in case of allocation error */ - newupval(L, 1, level, &L->openupval); - L->ptbc = NULL; /* no errors */ + lua_assert(level > L->tbclist); + if (l_isfalse(s2v(level))) + return; /* false doesn't need to be closed */ + checkclosemth(L, level); /* value must have a close method */ + while (level - L->tbclist > USHRT_MAX) { /* is delta too large? */ + L->tbclist += USHRT_MAX; /* create a dummy node at maximum delta */ + L->tbclist->tbclist.delta = USHRT_MAX; + L->tbclist->tbclist.isdummy = 1; } + level->tbclist.delta = level - L->tbclist; + level->tbclist.isdummy = 0; + L->tbclist = level; } @@ -181,23 +182,11 @@ void luaF_unlinkupval (UpVal *uv) { /* -** Close all upvalues up to the given stack level. A 'status' equal -** to NOCLOSINGMETH closes upvalues without running any __close -** metamethods. If there is a pending to-be-closed value, close -** it before anything else. +** Close all upvalues up to the given stack level. */ -void luaF_close (lua_State *L, StkId level, int status, int yy) { +void luaF_closeupval (lua_State *L, StkId level) { UpVal *uv; StkId upl; /* stack index pointed by 'uv' */ - if (unlikely(status == LUA_ERRMEM && L->ptbc != NULL)) { - ptrdiff_t levelrel = savestack(L, level); - upl = L->ptbc; - L->ptbc = NULL; /* remove from "list" before closing */ - prepcallclosemth(L, upl, status, yy); - level = restorestack(L, levelrel); - } - else - lua_assert(L->ptbc == NULL); /* must be empty for other status */ while ((uv = L->openupval) != NULL && (upl = uplevel(uv)) >= level) { TValue *slot = &uv->u.value; /* new position for value */ lua_assert(uplevel(uv) < L->top); @@ -208,9 +197,22 @@ void luaF_close (lua_State *L, StkId level, int status, int yy) { nw2black(uv); /* closed upvalues cannot be gray */ luaC_barrier(L, uv, slot); } - if (uv->tbc && status != NOCLOSINGMETH) { - ptrdiff_t levelrel = savestack(L, level); - prepcallclosemth(L, upl, status, yy); /* may change the stack */ + } +} + + +/* +** Close all upvalues and to-be-closed variables up to the given stack +** level. +*/ +void luaF_close (lua_State *L, StkId level, int status, int yy) { + ptrdiff_t levelrel = savestack(L, level); + luaF_closeupval(L, level); /* first, close the upvalues */ + while (L->tbclist >= level) { /* traverse tbc's down to that level */ + StkId tbc = L->tbclist; /* get variable index */ + L->tbclist -= tbc->tbclist.delta; /* remove it from list */ + if (!tbc->tbclist.isdummy) { /* not a dummy entry? */ + prepcallclosemth(L, tbc, status, yy); /* close variable */ level = restorestack(L, levelrel); } } |