summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBryn M. Reeves <bmr@redhat.com>2018-11-01 16:47:56 +0000
committerBryn M. Reeves <bmr@redhat.com>2018-11-01 16:47:56 +0000
commit813a83b2d6d9a35ead4f7b424fa39e513cb8b49e (patch)
tree52b531e36712f119f07a7bb1d770dba16873fd46
parentfa8d5e4e8132ec6d601a9642abfbdcc044880c27 (diff)
downloadlvm2-813a83b2d6d9a35ead4f7b424fa39e513cb8b49e.tar.gz
libdm-stats: move no regions warning after dm_stats_list()
It doesn't make sense to test or warn about the region count until the stats handle has been listed: at this point it may or may not contain valid information (but is guaranteed to be correct after the list).
-rw-r--r--libdm/libdm-stats.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/libdm/libdm-stats.c b/libdm/libdm-stats.c
index 94ad380e0..6b4e3d81e 100644
--- a/libdm/libdm-stats.c
+++ b/libdm/libdm-stats.c
@@ -2336,11 +2336,6 @@ int dm_stats_populate(struct dm_stats *dms, const char *program_id,
return 0;
}
- if (!dms->nr_regions) {
- log_error("No regions registered.");
- return 0;
- }
-
/* allow zero-length program_id for populate */
if (!program_id)
program_id = dms->program_id;
@@ -2352,6 +2347,11 @@ int dm_stats_populate(struct dm_stats *dms, const char *program_id,
goto_bad;
}
+ if (!dms->nr_regions) {
+ log_verbose("No stats regions registered: %s", dms->name);
+ return 0;
+ }
+
dms->walk_flags = DM_STATS_WALK_REGION;
dm_stats_walk_start(dms);
do {