diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2019-06-25 15:29:26 +0200 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2019-08-09 12:57:07 +0200 |
| commit | cc4a92b13c08f500c1dc0c7af95af599b1c15095 (patch) | |
| tree | e22b0322665514395bb27a0e81f09085a213888e | |
| parent | 46f1d17c743145d3ffa045557a6a792eb99f478a (diff) | |
| download | lvm2-cc4a92b13c08f500c1dc0c7af95af599b1c15095.tar.gz | |
cov: ensure cname exists before derefering it
Just make it clear to analyzers cname can't be NULL.
TODO: maybe exclude NULL at front of the function...
| -rw-r--r-- | tools/command.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/command.c b/tools/command.c index 724040e39..2e69effcb 100644 --- a/tools/command.c +++ b/tools/command.c @@ -1935,7 +1935,7 @@ void print_usage(struct command *cmd, int longhelp, int desc_first) * see print_common_options_cmd() */ - if ((cname->variants > 1) && cname->common_options[opt_enum]) + if (cname && (cname->variants > 1) && cname->common_options[opt_enum]) continue; printf("\n\t["); @@ -1975,7 +1975,7 @@ void print_usage(struct command *cmd, int longhelp, int desc_first) * see print_common_options_cmd() */ - if ((cname->variants > 1) && cname->common_options[opt_enum]) + if (cname && (cname->variants > 1) && cname->common_options[opt_enum]) continue; printf("\n\t["); @@ -3438,7 +3438,7 @@ static int _print_man(char *name, char *des_file, int secondary) if (!prev_cmd || strcmp(prev_cmd->name, cmd->name)) { printf(".SH NAME\n"); - if (cname->desc) + if (cname && cname->desc) printf("%s - %s\n", lvmname, cname->desc); else printf("%s\n", lvmname); |