diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2019-11-08 12:51:48 +0100 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2019-11-08 15:11:50 +0100 |
| commit | 34bde8b6c7e517239a05334683a09f2b5075fdcc (patch) | |
| tree | b5f1030ab66b45f258276d612983cb0a4cfd61cd | |
| parent | f90c3d69cedf94fa094bc71cc98376d58d970223 (diff) | |
| download | lvm2-34bde8b6c7e517239a05334683a09f2b5075fdcc.tar.gz | |
lvmcache: free resource on error path
Free allocated svg on error path.
Also explicitely ignore dm_strncpy() result.
(We know it will end with failure here.)
| -rw-r--r-- | lib/cache/lvmcache.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/cache/lvmcache.c b/lib/cache/lvmcache.c index 9890325d2..c12ec2b0c 100644 --- a/lib/cache/lvmcache.c +++ b/lib/cache/lvmcache.c @@ -325,10 +325,12 @@ void lvmcache_save_vg(struct volume_group *vg, int precommitted) dm_list_init(&svg->saved_vg_to_free); - dm_strncpy(svg->vgid, (const char *)vg->id.uuid, sizeof(svg->vgid)); + /* Ignore result code, size we intentionally short-cut & pad with 0 */ + (void) dm_strncpy(svg->vgid, (const char *)vg->id.uuid, sizeof(svg->vgid)); if (!dm_hash_insert(_saved_vg_hash, svg->vgid, svg)) { log_error("lvmcache: failed to insert saved_vg %s", svg->vgid); + dm_free(svg); return; } } else { |