diff options
| author | Bryn M. Reeves <bmr@redhat.com> | 2017-03-29 17:25:20 +0100 |
|---|---|---|
| committer | Bryn M. Reeves <bmr@redhat.com> | 2017-03-29 18:34:19 +0100 |
| commit | f66bc3dab07f3394150536819943a5c31ce793bf (patch) | |
| tree | 7a41c4d883a108bdd31a596973691912e3541782 | |
| parent | 8658bbe3eed38183554643f93f4c23718fd24827 (diff) | |
| download | lvm2-f66bc3dab07f3394150536819943a5c31ce793bf.tar.gz | |
dmfilemapd: fix off-by-one in fd comparison (coverity)
The function _filemap_monitor_check_file_unlinked() attempts to
test whether a fd value should be closed by comparison to zero:
if ((fd > 0) && close(fd))
log_error("Error closing fd %d", fd);
The test should be '>=' since 0 is a valid file descriptor.
| -rw-r--r-- | daemons/dmfilemapd/dmfilemapd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/daemons/dmfilemapd/dmfilemapd.c b/daemons/dmfilemapd/dmfilemapd.c index 0f3780be9..2fa51ee42 100644 --- a/daemons/dmfilemapd/dmfilemapd.c +++ b/daemons/dmfilemapd/dmfilemapd.c @@ -603,7 +603,7 @@ check_unlinked: else same = _filemap_monitor_check_same_file(fm->fd, fd); - if ((fd > 0) && close(fd)) + if ((fd >= 0) && close(fd)) log_error("Error closing fd %d", fd); if (same < 0) |