summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBryn M. Reeves <bmr@redhat.com>2015-08-10 19:05:10 +0100
committerBryn M. Reeves <bmr@redhat.com>2015-08-10 20:25:59 +0100
commitec87e88c5264511576341286b474b453a15594ba (patch)
treefe236156bf557e56cf3db001cd973da6e31d35d8
parentf9f5aac123d2244daeff92a692a03da3fea6bd74 (diff)
downloadlvm2-ec87e88c5264511576341286b474b453a15594ba.tar.gz
dmsetup: don't free handle if dm_stats_create fails (Coverity)
The error path of _stats_list frees the task and stats objects: don't try to branch to it before they have been allocated. tools/dmsetup.c: 4589 in _stats_help() - Null pointer dereferences (FORWARD_NULL)
-rw-r--r--tools/dmsetup.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/dmsetup.c b/tools/dmsetup.c
index 2ee432b3a..ed3cbd19d 100644
--- a/tools/dmsetup.c
+++ b/tools/dmsetup.c
@@ -4253,7 +4253,7 @@ static int _stats_list(CMD_ARGS)
return 1;
if (!(dms = dm_stats_create(DM_STATS_PROGRAM_ID)))
- goto_out;
+ return_0;
if (!_bind_stats_device(dms, name))
goto_out;