diff options
author | David Teigland <teigland@redhat.com> | 2019-09-13 11:20:36 -0500 |
---|---|---|
committer | David Teigland <teigland@redhat.com> | 2019-10-07 11:57:02 -0500 |
commit | bfbb94af61bb1faa858d6162b8c0210ef551d436 (patch) | |
tree | d55ddc687a856942dd6d2dd12c6a66f0dff71d66 | |
parent | b81d1bbfa8809150eb7c9ee221194242e168361f (diff) | |
download | lvm2-bfbb94af61bb1faa858d6162b8c0210ef551d436.tar.gz |
lvconvert: drop warnings related to missing cachevol repair
-rw-r--r-- | tools/lvconvert.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/tools/lvconvert.c b/tools/lvconvert.c index 145948a91..258e88721 100644 --- a/tools/lvconvert.c +++ b/tools/lvconvert.c @@ -2484,7 +2484,7 @@ static int _lvconvert_cache_repair(struct cmd_context *cmd, struct logical_volume *mlv; if (lv_is_cache(cache_lv) && lv_is_cache_vol(first_seg(cache_lv)->pool_lv)) { - log_error("Manual repair required."); + log_error("Repair cachevol with lvconvert --repaircachevol"); return 0; } @@ -3475,14 +3475,6 @@ static int _cache_vol_attach(struct cmd_context *cmd, if (!cache_vol_set_params(cmd, cache_lv, lv_fast, poolmetadatasize, chunk_size, cache_metadata_format, cache_mode, policy_name, policy_settings)) goto_out; - if (cache_mode == CACHE_MODE_WRITEBACK) { - log_warn("WARNING: repairing a damaged cachevol is not yet possible."); - log_warn("WARNING: cache mode writethrough is suggested for safe operation."); - if (!arg_count(cmd, yes_ARG) && - yes_no_prompt("Continue using writeback without repair?") == 'n') - goto_out; - } - /* * lv/cache_lv keeps the same lockd lock it had before, the lock for * lv_fast is freed, and lv_corig has no lock. @@ -4222,8 +4214,6 @@ static int _lvconvert_repair_cachevol_single(struct cmd_context *cmd, struct log * * FIXME: we should have an LV maintenance mode that we set on this LV * while it's being repaired to prevent other usage. - * - * FIXME: make it an error to activate the cache LV while its cachevol is active. */ unlock_vg(cmd, vg, vg->name); |