summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2016-10-03 14:37:08 +0200
committerZdenek Kabelac <zkabelac@redhat.com>2016-10-03 17:49:56 +0200
commit77ffd39dfb4145e444fb9ab2394d807207db8083 (patch)
tree46e0d75509ca8881b85e18b660c9f97b951ab7e4
parent9fe4f2337bfaaa30e647ed1d20be7fb76d598559 (diff)
downloadlvm2-77ffd39dfb4145e444fb9ab2394d807207db8083.tar.gz
cleanup: drop test for NULL
Since lp->segtype has been already checked for not-being NULL, drop this test so Coverity is not later confused it 'can be a NULL'.
-rw-r--r--tools/lvconvert.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index 3607247b4..2f38c9d51 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -4460,7 +4460,8 @@ static int _lvconvert(struct cmd_context *cmd, struct logical_volume *lv,
}
}
- if (activation() && lp->segtype && lp->segtype->ops->target_present &&
+ /* lv->segtype can't be NULL */
+ if (activation() && lp->segtype->ops->target_present &&
!lp->segtype->ops->target_present(cmd, NULL, &lp->target_attr)) {
log_error("%s: Required device-mapper target(s) not "
"detected in your kernel.", lp->segtype->name);