summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlasdair G Kergon <agk@redhat.com>2016-08-15 19:38:45 +0100
committerAlasdair G Kergon <agk@redhat.com>2016-08-15 19:38:45 +0100
commit114db6f745a229e1c3bf2dc95cc45c020cbcfca8 (patch)
tree049f07c0428e628b72427fef619230cbf5013213
parentd83f2d766d3177e2d2509f4fddb9b6f9c7fac7bc (diff)
downloadlvm2-114db6f745a229e1c3bf2dc95cc45c020cbcfca8.tar.gz
tools: Suppress some unnecessary --stripesize warnings.
https://bugzilla.redhat.com/1366745
-rw-r--r--WHATS_NEW1
-rw-r--r--tools/toollib.c8
2 files changed, 6 insertions, 3 deletions
diff --git a/WHATS_NEW b/WHATS_NEW
index 60bdc4f6c..ae6bbea51 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
Version 2.02.165 -
===================================
+ Suppress some unnecessary --stripesize parameter warnings.
Fix 'pvmove -n name ...' to prohibit collocation of RAID SubLVs
Version 2.02.164 - 15th August 2016
diff --git a/tools/toollib.c b/tools/toollib.c
index e24946fff..4f8cbb4af 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -1281,10 +1281,12 @@ static int _validate_stripe_params(struct cmd_context *cmd, const struct segment
if (!stripe_size_required && *stripe_size) {
log_print_unless_silent("Ignoring stripesize argument for %s devices.", segtype->name);
*stripe_size = 0;
- } else if (segtype_is_striped(segtype) && *stripes == 1 && *stripe_size) {
- log_print_unless_silent("Ignoring stripesize argument with single stripe.");
+ } else if (*stripes == 1 && (segtype_is_striped(segtype) || segtype_is_mirror(segtype))) {
stripe_size_required = 0;
- *stripe_size = 0;
+ if (*stripe_size) {
+ log_print_unless_silent("Ignoring stripesize argument with single stripe.");
+ *stripe_size = 0;
+ }
}
if (stripe_size_required) {