summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2016-10-03 13:04:16 +0200
committerZdenek Kabelac <zkabelac@redhat.com>2016-10-03 17:49:55 +0200
commit9fe4f2337bfaaa30e647ed1d20be7fb76d598559 (patch)
tree0696e1f081309b9f05d479f26aa019819846c707
parentcea441f4d1e19f170d9161203ef843c59f3fbf70 (diff)
downloadlvm2-9fe4f2337bfaaa30e647ed1d20be7fb76d598559.tar.gz
cleanup: drop assign before use
Drop unneeded assigns singe vars are set later in code before their first use (Coverity).
-rw-r--r--daemons/lvmetad/lvmetad-core.c2
-rw-r--r--lib/cache/lvmcache.c2
-rw-r--r--lib/metadata/raid_manip.c2
-rw-r--r--lib/metadata/thin_manip.c2
4 files changed, 4 insertions, 4 deletions
diff --git a/daemons/lvmetad/lvmetad-core.c b/daemons/lvmetad/lvmetad-core.c
index 36a5cec74..ee0c52fa8 100644
--- a/daemons/lvmetad/lvmetad-core.c
+++ b/daemons/lvmetad/lvmetad-core.c
@@ -1249,8 +1249,8 @@ static int _update_metadata(lvmetad_state *s, const char *arg_name, const char *
const char *old_vgid = NULL;
const char *new_vgid = NULL;
const char *new_metadata_vgid;
+ int new_seq;
int old_seq = -1;
- int new_seq = -1;
int needs_repair = 0;
int abort_daemon = 0;
int retval = 0;
diff --git a/lib/cache/lvmcache.c b/lib/cache/lvmcache.c
index 5e402f09e..a15481f39 100644
--- a/lib/cache/lvmcache.c
+++ b/lib/cache/lvmcache.c
@@ -858,7 +858,7 @@ static void _choose_preferred_devs(struct cmd_context *cmd,
struct dm_list *add_cache_devs)
{
char uuid[64] __attribute__((aligned(8)));
- const char *reason = "none";
+ const char *reason;
struct dm_list altdevs;
struct dm_list new_unused;
struct dev_types *dt = cmd->dev_types;
diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c
index f8a3c466b..e87a4e5b9 100644
--- a/lib/metadata/raid_manip.c
+++ b/lib/metadata/raid_manip.c
@@ -956,7 +956,7 @@ static int _raid_add_images(struct logical_volume *lv,
int commit, int use_existing_area_len)
{
int rebuild_flag_cleared = 0;
- struct lv_segment *seg = first_seg(lv);
+ struct lv_segment *seg;
uint32_t s;
if (!_raid_add_images_without_commit(lv, new_count, pvs, use_existing_area_len))
diff --git a/lib/metadata/thin_manip.c b/lib/metadata/thin_manip.c
index a02a7e69f..e7a2c33e3 100644
--- a/lib/metadata/thin_manip.c
+++ b/lib/metadata/thin_manip.c
@@ -472,7 +472,7 @@ static int _check_pool_create(const struct logical_volume *lv)
int update_pool_lv(struct logical_volume *lv, int activate)
{
- int monitored = DMEVENTD_MONITOR_IGNORE;
+ int monitored;
int ret = 1;
if (!lv_is_thin_pool(lv)) {