diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2016-10-31 18:03:06 +0100 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2016-11-03 17:49:07 +0100 |
| commit | e3775173b41f0cd4dfaeab84a235e167d9603618 (patch) | |
| tree | a5ad287d3166cf5da2da3df56b45ae0c9ccddc0c | |
| parent | ee13f265f043b47a1b023321fb9e8470fb5703c1 (diff) | |
| download | lvm2-e3775173b41f0cd4dfaeab84a235e167d9603618.tar.gz | |
cleanup: log_info to log_error
Switch to more appropriate logging level.
| -rw-r--r-- | WHATS_NEW | 1 | ||||
| -rw-r--r-- | WHATS_NEW_DM | 1 | ||||
| -rw-r--r-- | daemons/dmeventd/plugins/raid/dmeventd_raid.c | 2 | ||||
| -rw-r--r-- | lib/filters/filter-regex.c | 4 | ||||
| -rw-r--r-- | lib/filters/filter-sysfs.c | 2 |
5 files changed, 6 insertions, 4 deletions
@@ -1,5 +1,6 @@ Version 2.02.167 - ====================================== + Use log_error in regex and sysfs filter to describe reason of failure. Fix blkdeactivate to deactivate dev stack if dev on top already unmounted. Prevent non-synced raid1 repair unless --force Prevent raid4 creation/conversion on non-supporting kernels diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM index a4dd6eb82..17c370cd5 100644 --- a/WHATS_NEW_DM +++ b/WHATS_NEW_DM @@ -1,5 +1,6 @@ Version 1.02.136 - ====================================== + Log failure of raid device with log_error level. Use dm_log_with_errno and translate runtime to dm_log only when needed. Make log messages from dm and lvm library differnt from dmeventd. Notice and Info messages are again logged from dmeventd and its plugins. diff --git a/daemons/dmeventd/plugins/raid/dmeventd_raid.c b/daemons/dmeventd/plugins/raid/dmeventd_raid.c index ee18793cc..9df5f1d55 100644 --- a/daemons/dmeventd/plugins/raid/dmeventd_raid.c +++ b/daemons/dmeventd/plugins/raid/dmeventd_raid.c @@ -76,7 +76,7 @@ static int _process_raid_event(struct dso_state *state, char *params, const char /* if repair goes OK, report success even if lvscan has failed */ if (!dmeventd_lvm2_run_with_lock(state->cmd_lvconvert)) { - log_info("Repair of RAID device %s failed.", device); + log_error("Repair of RAID device %s failed.", device); r = 0; } } else { diff --git a/lib/filters/filter-regex.c b/lib/filters/filter-regex.c index b8d229b58..f7cc07210 100644 --- a/lib/filters/filter-regex.c +++ b/lib/filters/filter-regex.c @@ -40,7 +40,7 @@ static int _extract_pattern(struct dm_pool *mem, const char *pat, break; default: - log_info("pattern must begin with 'a' or 'r'"); + log_error("Pattern must begin with 'a' or 'r'."); return 0; } pat++; @@ -77,7 +77,7 @@ static int _extract_pattern(struct dm_pool *mem, const char *pat, */ ptr = r + strlen(r) - 1; if (*ptr != sep) { - log_info("invalid separator at end of regex"); + log_error("Invalid separator at end of regex."); return 0; } *ptr = '\0'; diff --git a/lib/filters/filter-sysfs.c b/lib/filters/filter-sysfs.c index 6f566bccf..6dacd5d80 100644 --- a/lib/filters/filter-sysfs.c +++ b/lib/filters/filter-sysfs.c @@ -168,7 +168,7 @@ static int _parse_dev(const char *file, FILE *fp, dev_t *result) } if (sscanf(buffer, "%u:%u", &major, &minor) != 2) { - log_info("sysfs device file not correct format"); + log_error("Incorrect format for sysfs device file: %s.", file); return 0; } |