diff options
author | Zdenek Kabelac <zkabelac@redhat.com> | 2016-12-18 15:06:12 +0100 |
---|---|---|
committer | Zdenek Kabelac <zkabelac@redhat.com> | 2016-12-18 19:38:51 +0100 |
commit | 79121416dfd695900a02711e6f63146e532b825b (patch) | |
tree | 692d7095162cf8bd1b0d56e3e6d0b69a2d185193 | |
parent | 75f23880934a8c1cb192e9a898261320db15043a (diff) | |
download | lvm2-79121416dfd695900a02711e6f63146e532b825b.tar.gz |
thin: add comment with future extension
It could be actually better to use even cache origin in
read-only mode so there could no be some 'acidental'
change being done on this volume.
This however need further tools enhancment - where we would need
to handle whole subtree on 'lvchange -pr/-prw'.
-rw-r--r-- | lib/metadata/thin_manip.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/metadata/thin_manip.c b/lib/metadata/thin_manip.c index e7a2c33e3..42ec552d7 100644 --- a/lib/metadata/thin_manip.c +++ b/lib/metadata/thin_manip.c @@ -99,6 +99,10 @@ int attach_thin_external_origin(struct lv_segment *seg, external_lv->name); external_lv->status &= ~LVM_WRITE; } + + // TODO: should we mark even origin read-only ? + //if (lv_is_cache(external_lv)) /* read-only corigin of cache LV */ + // seg_lv(first_seg(external_lv), 0)->status &= ~LVM_WRITE; } return 1; |