summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2016-01-13 10:43:01 -0600
committerDavid Teigland <teigland@redhat.com>2016-01-13 10:46:04 -0600
commitbe1b1f3d8941543bcde2f42e65ed0f22fd07b122 (patch)
tree13df5fad0e19d6b5f322b79e12b729b83419f034
parent63d59254d95e29a4e6ca47cadfb15cf821ec7479 (diff)
downloadlvm2-be1b1f3d8941543bcde2f42e65ed0f22fd07b122.tar.gz
process_each_pv: remove unnecessary workaround
The problem addressed by this workaround no longer seems to exist, so remove it. PVs with no mdas no longer appear in both their actual VG and in the orphan VG.
-rw-r--r--tools/toollib.c17
1 files changed, 1 insertions, 16 deletions
diff --git a/tools/toollib.c b/tools/toollib.c
index 728e61d4d..97cc1bf6e 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -3033,7 +3033,6 @@ static int _process_pvs_in_vg(struct cmd_context *cmd,
const char *pv_name;
int selected;
int process_pv;
- int dev_found;
int ret_max = ECMD_PROCESSED;
int ret = 0;
@@ -3087,21 +3086,7 @@ static int _process_pvs_in_vg(struct cmd_context *cmd,
else
log_very_verbose("Processing PV %s in VG %s.", pv_name, vg->name);
- dev_found = _device_list_remove(all_devices, pv->dev);
-
- /*
- * FIXME PVs with no mdas may turn up in an orphan VG when
- * not using lvmetad as well as their correct VG. They
- * will be missing from all_devices the second time
- * around but must not be processed twice or trigger a message.
- *
- * Missing PVs will also need processing even though they are
- * not present in all_devices.
- */
- if (!dev_found && !is_missing_pv(pv)) {
- log_verbose("Skipping PV %s in VG %s: not in device list.", pv_name, vg->name);
- continue;
- }
+ _device_list_remove(all_devices, pv->dev);
if (!skip) {
ret = process_single_pv(cmd, vg, pv, handle);