diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2021-02-02 19:53:59 +0100 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2021-02-02 21:23:39 +0100 |
| commit | 51c83f14837c8647c3522abb23707da3ece2085c (patch) | |
| tree | e2491709e78e3f46b1391757a36e8125d5fa0929 | |
| parent | 8454ce66c511438ef0d9da3d3b0bac2a5a3d8f2b (diff) | |
| download | lvm2-51c83f14837c8647c3522abb23707da3ece2085c.tar.gz | |
lvcreate: use lv_passes_readonly_filter
Check if created LV is going to be activated read-only
because such LV cannot be zeroed (equals to use
option '-pr').
| -rw-r--r-- | WHATS_NEW | 1 | ||||
| -rw-r--r-- | lib/activate/activate.c | 5 | ||||
| -rw-r--r-- | lib/activate/activate.h | 2 | ||||
| -rw-r--r-- | lib/metadata/lv_manip.c | 6 |
4 files changed, 14 insertions, 0 deletions
@@ -1,5 +1,6 @@ Version 2.03.12 - =================================== + Check if lvcreate passes read_only_volume_list with tags and skips zeroing. Allocation prints better error when metadata cannot fit on a single PV. Pvmove can better resolve full thin-pool tree move. Limit pool metadata spare to 16GiB. diff --git a/lib/activate/activate.c b/lib/activate/activate.c index 7ed644113..de866fb6c 100644 --- a/lib/activate/activate.c +++ b/lib/activate/activate.c @@ -466,6 +466,11 @@ static int _passes_readonly_filter(struct cmd_context *cmd, return _lv_passes_volumes_filter(cmd, lv, cn, activation_read_only_volume_list_CFG); } +int lv_passes_readonly_filter(const struct logical_volume *lv) +{ + return _passes_readonly_filter(lv->vg->cmd, lv); +} + int library_version(char *version, size_t size) { if (!activation()) diff --git a/lib/activate/activate.h b/lib/activate/activate.h index 3f4d128be..53c8631b4 100644 --- a/lib/activate/activate.h +++ b/lib/activate/activate.h @@ -208,6 +208,8 @@ int lvs_in_vg_opened(const struct volume_group *vg); int lv_is_active(const struct logical_volume *lv); +int lv_passes_readonly_filter(const struct logical_volume *lv); + /* Check is any component LV is active */ const struct logical_volume *lv_component_is_active(const struct logical_volume *lv); const struct logical_volume *lv_holder_is_active(const struct logical_volume *lv); diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c index d101fa582..29c95ff63 100644 --- a/lib/metadata/lv_manip.c +++ b/lib/metadata/lv_manip.c @@ -7987,6 +7987,12 @@ static int _should_wipe_lv(struct lvcreate_params *lp, first_seg(first_seg(lv)->pool_lv)->zero_new_blocks)) return 0; + if (warn && (lv_passes_readonly_filter(lv))) { + log_warn("WARNING: Read-only activated logical volume %s not zeroed.", + display_lvname(lv)); + return 0; + } + /* Cannot zero read-only volume */ if ((lv->status & LVM_WRITE) && (lp->zero || lp->wipe_signatures)) |