summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOndrej Kozina <okozina@redhat.com>2015-04-16 17:46:38 +0200
committerOndrej Kozina <okozina@redhat.com>2015-04-16 17:54:00 +0200
commit061e371319676a914a65f07678d0d15f4000c468 (patch)
tree3e6198aeb8c02a1458a6c83aa9ec180b249e9ed2
parent105c07d1b4d34191ed939f53d98b253e620e449b (diff)
downloadlvm2-061e371319676a914a65f07678d0d15f4000c468.tar.gz
pvmove: fix wrong error path in _update_metadata
fix regression introduced in 65623b63a20a221b48dfd87455dc77f5ac0c6bf4 should return zero no matter the result of resume_lvs fn in error path
-rw-r--r--tools/pvmove.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/tools/pvmove.c b/tools/pvmove.c
index bef900b76..6acac42da 100644
--- a/tools/pvmove.c
+++ b/tools/pvmove.c
@@ -531,10 +531,9 @@ static int _update_metadata(struct cmd_context *cmd, struct volume_group *vg,
/* Commit on-disk metadata */
if (!vg_commit(vg)) {
log_error("ABORTING: First volume group metadata update failed.");
- if (!resume_lvs(cmd, lvs_changed)) {
+ if (!resume_lvs(cmd, lvs_changed))
log_error("Unable to resume logical volumes.");
- return 0;
- }
+ return 0;
}
/* Activate the temporary mirror LV */