diff options
| author | Peter Rajnoha <prajnoha@redhat.com> | 2015-07-09 13:11:57 +0200 |
|---|---|---|
| committer | Peter Rajnoha <prajnoha@redhat.com> | 2015-07-09 13:11:57 +0200 |
| commit | a9a7c297aebe82ddc9092b7b19cc9cfcc27e117e (patch) | |
| tree | 1aa6f60b16c3ec6f033ad1b23fd70375a64fe10c | |
| parent | 023cf21848bdf75bade560f6f43b2dea62a54f80 (diff) | |
| download | lvm2-a9a7c297aebe82ddc9092b7b19cc9cfcc27e117e.tar.gz | |
coverity: missing return value for dm_split_lvm_name pass proper DM name instead of NULL value
| -rw-r--r-- | daemons/lvmlockd/lvmlockd-core.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/daemons/lvmlockd/lvmlockd-core.c b/daemons/lvmlockd/lvmlockd-core.c index ff5510c0e..eee1da1e0 100644 --- a/daemons/lvmlockd/lvmlockd-core.c +++ b/daemons/lvmlockd/lvmlockd-core.c @@ -4726,7 +4726,10 @@ static int remove_inactive_lvs(struct list_head *vg_lockd) strncpy(namebuf, names->name, MAX_NAME); vgname = namebuf; - dm_split_lvm_name(NULL, NULL, &vgname, &lvname, &layer); + if (!dm_split_lvm_name(NULL, namebuf, &vgname, &lvname, &layer)) { + log_error("failed to split dm name %s", namebuf); + goto next_dmname; + } log_debug("adopt remove_inactive dm name %s dm uuid %s vgname %s lvname %s", names->name, dm_uuid, vgname, lvname); |