diff options
| author | Peter Rajnoha <prajnoha@redhat.com> | 2014-12-05 15:10:50 +0100 |
|---|---|---|
| committer | Peter Rajnoha <prajnoha@redhat.com> | 2014-12-05 15:10:50 +0100 |
| commit | 42d71b9af393bdbf0e9409eea176b2801a07ea25 (patch) | |
| tree | d8606c311d24dc684a94abfe9fc0ed69b917fe8e | |
| parent | f867dc6b294c434e69499e38e66a67812361d8c9 (diff) | |
| download | lvm2-42d71b9af393bdbf0e9409eea176b2801a07ea25.tar.gz | |
libdm: report: return immediately from dm_report_compact_fields without error if there are no rows
Let's make dm_report_compact_fields consistent with dm_report_output fn
which also returns with success immediately if there are no rows.
| -rw-r--r-- | libdm/libdm-report.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/libdm/libdm-report.c b/libdm/libdm-report.c index f81d964ee..6d36c1e1a 100644 --- a/libdm/libdm-report.c +++ b/libdm/libdm-report.c @@ -1696,11 +1696,12 @@ int dm_report_compact_fields(struct dm_report *rh) struct field_properties *fp; struct row *row; - if (!(rh->flags & DM_REPORT_OUTPUT_BUFFERED)) + if (!(rh->flags & DM_REPORT_OUTPUT_BUFFERED) || + dm_list_empty(&rh->rows)) return 1; - if (!rh || dm_list_empty(&rh->rows)) { - log_error("dm_report_enable_compact_output: no report fields to compact"); + if (!rh) { + log_error("dm_report_enable_compact_output: dm report handler is NULL."); return 0; } |