summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2019-11-28 15:09:27 +0100
committerZdenek Kabelac <zkabelac@redhat.com>2019-12-10 15:44:16 +0100
commitabc0a8faba2a1437f4f9d158310acb8af6ab2fe5 (patch)
treef29cf263fe4aca6b9a28920e2632e53285f4fb2e
parent5555765cfc71a87eadcb1f6ac9bdd41f2e3c9052 (diff)
downloadlvm2-abc0a8faba2a1437f4f9d158310acb8af6ab2fe5.tar.gz
vg_read: use else for 3 case
Make it visible we check for ==, >, < of same var.
-rw-r--r--lib/metadata/metadata.c11
1 files changed, 2 insertions, 9 deletions
diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c
index 5856a921e..24958d04c 100644
--- a/lib/metadata/metadata.c
+++ b/lib/metadata/metadata.c
@@ -4878,10 +4878,7 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,
if (vg->seqno == vg_ret->seqno) {
release_vg(vg);
- continue;
- }
-
- if (vg->seqno > vg_ret->seqno) {
+ } else if (vg->seqno > vg_ret->seqno) {
log_warn("WARNING: ignoring metadata seqno %u on %s for seqno %u on %s for VG %s.",
vg_ret->seqno, dev_name(dev_ret),
vg->seqno, dev_name(mda_dev), vg->name);
@@ -4890,17 +4887,13 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,
vg_ret = vg;
dev_ret = mda_dev;
vg_fmtdata = NULL;
- continue;
- }
-
- if (vg_ret->seqno > vg->seqno) {
+ } else { /* vg->seqno < vg_ret->seqno */
log_warn("WARNING: ignoring metadata seqno %u on %s for seqno %u on %s for VG %s.",
vg->seqno, dev_name(mda_dev),
vg_ret->seqno, dev_name(dev_ret), vg->name);
found_old_metadata = 1;
release_vg(vg);
vg_fmtdata = NULL;
- continue;
}
}