summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2020-02-03 11:33:30 -0600
committerDavid Teigland <teigland@redhat.com>2020-02-03 11:33:30 -0600
commitadbb0a8d5bd0f735a756e32effcf0bddac0f6de7 (patch)
tree5344ceebdb0597a6165d69fe7ee9d862ca3dd85e
parent64a82a1c79a4aaef5359150f960932aee4df1982 (diff)
downloadlvm2-adbb0a8d5bd0f735a756e32effcf0bddac0f6de7.tar.gz
writecache: reject invalid high/low watermark setting
-rw-r--r--tools/lvconvert.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index d0d277bcd..f6a329b22 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -5504,6 +5504,12 @@ static int _get_writecache_settings(struct cmd_context *cmd, struct writecache_s
}
}
+ if (settings->high_watermark_set && settings->low_watermark_set &&
+ (settings->high_watermark <= settings->low_watermark)) {
+ log_error("High watermark must be greater than or equal to low watermark.");
+ return 0;
+ }
+
return 1;
}