summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2020-02-06 11:27:33 -0600
committerDavid Teigland <teigland@redhat.com>2020-02-06 11:27:33 -0600
commitffea7daec3d09fb4315104bb346cfa9d6db6f9e9 (patch)
tree1d422a0a5bc0bab5c392fa9e71db33421d3b9278
parent2a6078f96168e860474b42c42b1924fc353c4558 (diff)
downloadlvm2-ffea7daec3d09fb4315104bb346cfa9d6db6f9e9.tar.gz
writecache: prevent snapshots
there appear to be problems with taking a snapshot of an LV with a writecache, so block it until that is understood or fixed.
-rw-r--r--lib/metadata/snapshot_manip.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/metadata/snapshot_manip.c b/lib/metadata/snapshot_manip.c
index e58aea487..64e27ae83 100644
--- a/lib/metadata/snapshot_manip.c
+++ b/lib/metadata/snapshot_manip.c
@@ -385,8 +385,11 @@ int validate_snapshot_origin(const struct logical_volume *origin_lv)
log_warn("WARNING: Consider using the raid1 mirror type to avoid this.");
log_warn("WARNING: See global/mirror_segtype_default in lvm.conf.");
}
- } else if (lv_is_raid_type(origin_lv) && !lv_is_raid(origin_lv))
+ } else if (lv_is_raid_type(origin_lv) && !lv_is_raid(origin_lv)) {
err = "raid subvolumes";
+ } else if (lv_is_writecache(origin_lv)) {
+ err = "writecache";
+ }
if (err) {
log_error("Snapshots of %s are not supported.", err);