summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2016-04-07 13:45:26 -0500
committerDavid Teigland <teigland@redhat.com>2016-04-19 09:40:24 -0500
commite41ee70accbc604e3a7daea0ab10f9405e95a531 (patch)
treeb8686cb42105fd726bf55434576f4273a4cd797d
parenta6a32a7c0e6ed9ef9e61e82b2d1353a1c06a9dd3 (diff)
downloadlvm2-e41ee70accbc604e3a7daea0ab10f9405e95a531.tar.gz
toollib: remove unneeded call in process_each_pv
process_each_pv was doing: 1. lvmcache_seed_infos_from_lvmetad() sends pv_list request to lvmetad. 2. get_vgnameids() sends vg_list request to lvmetad. 3. _get_all_devices() first calls lvmcache_seed_infos_from_lvmetad(), which is a no-op if it's already been called. Because get_vgnameids() does not use the information from lvmcache_seed_infos_from_lvmetad(), it does not need to be called prior to get_all_devices where it is actually needed.
-rw-r--r--tools/toollib.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/tools/toollib.c b/tools/toollib.c
index b9db9cb31..ac2a57a48 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -3372,12 +3372,6 @@ int process_each_pv(struct cmd_context *cmd,
dev_cache_full_scan(cmd->full_filter);
}
- /*
- * Need pvid's set on all PVs before processing so that pvid's
- * can be compared to find duplicates while processing.
- */
- lvmcache_seed_infos_from_lvmetad(cmd);
-
if (!get_vgnameids(cmd, &all_vgnameids, only_this_vgname, 1)) {
stack;
return ret;