diff options
| author | Peter Rajnoha <prajnoha@redhat.com> | 2016-03-24 11:13:21 +0100 |
|---|---|---|
| committer | Peter Rajnoha <prajnoha@redhat.com> | 2016-03-24 12:40:19 +0100 |
| commit | 6129d2e64d14047169048775dc7081135c0fcc50 (patch) | |
| tree | 544959d4d8ac63a2ce732b86ae6598eced1dba05 | |
| parent | 82d92009ae37bea3cd6a3f754c25d56b12959676 (diff) | |
| download | lvm2-6129d2e64d14047169048775dc7081135c0fcc50.tar.gz | |
monitoring: sync /dev content before contacting dmeventd for monitor/unmonitor
dmeventd daemon may call further code itself that looks at /dev, e.g.
via dmeventd_lvm2_command call. We need to have a consistent view of
the /dev content at that time. Therefore, sync /dev content before
calling monitoring hook which contacts dmeventd.
This problem was quite hidden before, but now it has manifested itself
because of recent additions to dev-cache code where we started looking
at device holders as seen in sysfs. What happened here was that the
device was already in sysfs, but not yet under /dev and this triggered
the new error message sometimes:
log_error("%s: failed to find associated device structure for holder %s.", devname, devpath);
This problem has manifested recently in our api/pytest.sh test from
testsuite where we create thin pool LVs and thin LVs and hence it also
causes dmeventd to be used as well and these error messages were
visible there.
| -rw-r--r-- | lib/activate/activate.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/lib/activate/activate.c b/lib/activate/activate.c index 2eb24d49b..7dce0da76 100644 --- a/lib/activate/activate.c +++ b/lib/activate/activate.c @@ -1746,6 +1746,12 @@ int monitor_dev_for_events(struct cmd_context *cmd, const struct logical_volume if (test_mode()) continue; + /* + * Sync all queued device names/symlinks so dmeventd + * has consistent view during possible device scan. + */ + fs_unlock(); + /* FIXME specify events */ if (!monitor_fn(seg, 0)) { log_error("%s: %s segment monitoring function failed.", |