diff options
| author | Alasdair G Kergon <agk@redhat.com> | 2015-03-09 18:56:24 +0000 |
|---|---|---|
| committer | Alasdair G Kergon <agk@redhat.com> | 2015-03-09 18:56:24 +0000 |
| commit | a8545462349c560cf66362cb3d25b44b7b0e819b (patch) | |
| tree | 84c3dec9fd7b757c7e4784b3e30949474308e744 | |
| parent | faccdeda83ee8c04546a2224fa2dee82a55413fe (diff) | |
| download | lvm2-a8545462349c560cf66362cb3d25b44b7b0e819b.tar.gz | |
metadata: Detect internal use of LVM_WRITE_LOCKED.
Generate internal error if LVM_WRITE_LOCKED ever appears
in struct volume_group: it's only used in external
metadata.
| -rw-r--r-- | lib/metadata/metadata.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c index ab23d257c..21066fb37 100644 --- a/lib/metadata/metadata.c +++ b/lib/metadata/metadata.c @@ -2495,6 +2495,12 @@ int vg_validate(struct volume_group *vg) r = 0; } + if (vg->status & LVM_WRITE_LOCKED) { + log_error(INTERNAL_ERROR "VG %s has external flag LVM_WRITE_LOCKED set internally.", + vg->name); + r = 0; + } + /* FIXME Also check there's no data/metadata overlap */ if (!(vhash.pvid = dm_hash_create(vg->pv_count))) { log_error("Failed to allocate pvid hash."); @@ -2568,6 +2574,12 @@ int vg_validate(struct volume_group *vg) dm_list_iterate_items(lvl, &vg->lvs) { lv_count++; + if (lvl->lv->status & LVM_WRITE_LOCKED) { + log_error(INTERNAL_ERROR "LV %s has external flag LVM_WRITE_LOCKED set internally.", + vg->name); + r = 0; + } + dev_name_len = strlen(lvl->lv->name) + vg_name_len + 3; if (dev_name_len >= NAME_LEN) { log_error(INTERNAL_ERROR "LV name \"%s/%s\" length %" |