summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2014-10-31 13:04:46 +0100
committerZdenek Kabelac <zkabelac@redhat.com>2014-11-03 14:19:31 +0100
commited2a0560ad23f3de0b63e4c48ce91e6d5c744c23 (patch)
tree9281a69382999e58b7c4a421ad8da81cf051ad74
parente09ee21fd46287ed245ea086ddcf06140a83431a (diff)
downloadlvm2-ed2a0560ad23f3de0b63e4c48ce91e6d5c744c23.tar.gz
libdm: init char array
When non-root uses dm_check_version() it's been printing some unit values from stack. So always init those vars.
-rw-r--r--WHATS_NEW_DM1
-rw-r--r--libdm/ioctl/libdm-iface.c2
2 files changed, 2 insertions, 1 deletions
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 6981f8f1e..6b5ee3a0f 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,6 @@
Version 1.02.91 -
====================================
+ Don't print uninitialized stack bytes when non-root uses dm_check_version().
Fix selection criteria to not match reserved values when using >, <, >=, <.
Add DM_LIST_HEAD_INIT macro to libdevmapper.h
Fix dm_is_dm_major to not issue error about missing /proc lines for dm module.
diff --git a/libdm/ioctl/libdm-iface.c b/libdm/ioctl/libdm-iface.c
index c308fd26a..4c37a539b 100644
--- a/libdm/ioctl/libdm-iface.c
+++ b/libdm/ioctl/libdm-iface.c
@@ -544,7 +544,7 @@ static int _check_version(char *version, size_t size, int log_suppress)
*/
int dm_check_version(void)
{
- char libversion[64], dmversion[64];
+ char libversion[64] = "", dmversion[64] = "";
const char *compat = "";
if (_version_checked)