diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2021-04-23 14:44:57 +0200 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2021-04-23 22:54:41 +0200 |
| commit | 5e8307f4bfc6e04cd601fea78129302ce02ffef8 (patch) | |
| tree | a2d09fa2b4d21e67a2a75cc5208183caca14e6c2 | |
| parent | 66dd481f46099dd118136dacfad0e815e781605a (diff) | |
| download | lvm2-5e8307f4bfc6e04cd601fea78129302ce02ffef8.tar.gz | |
lvmcache: fix memory leak
With commit 0b18c25d934564015402de33e15a267045ed1b8c there
was introduced 'zalloc()' for allocation of outdates pvs,
but no matching 'free()' is present.
Switch to use cmd mempool instead of adding free() code into
several places.
| -rw-r--r-- | WHATS_NEW | 1 | ||||
| -rw-r--r-- | lib/cache/lvmcache.c | 2 |
2 files changed, 2 insertions, 1 deletions
@@ -1,5 +1,6 @@ Version 2.03.12 - =================================== + Fix memleak when generating list of outdated pvs. Better hyphenation usage in man pages. Replace use of deprecated security_context_t with char*. Configure supports AIO_LIBS and AIO_CFLAGS. diff --git a/lib/cache/lvmcache.c b/lib/cache/lvmcache.c index d4acec509..017134d7d 100644 --- a/lib/cache/lvmcache.c +++ b/lib/cache/lvmcache.c @@ -2818,7 +2818,7 @@ void lvmcache_get_outdated_devs(struct cmd_context *cmd, } dm_list_iterate_items(info, &vginfo->outdated_infos) { - if (!(devl = zalloc(sizeof(*devl)))) + if (!(devl = dm_pool_zalloc(cmd->mem, sizeof(*devl)))) return; devl->dev = info->dev; dm_list_add(devs, &devl->list); |