diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2021-04-23 22:47:18 +0200 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2021-04-23 23:00:55 +0200 |
| commit | cdcd8011d05a0cb7c6a07800dae2a0f99da8a5ee (patch) | |
| tree | 8862f939469b7d7fe506d157800f6d1f9c4f27fa | |
| parent | d388b36da236e66dd42e59d7b5c9d596d6de1961 (diff) | |
| download | lvm2-cdcd8011d05a0cb7c6a07800dae2a0f99da8a5ee.tar.gz | |
cov: add explicit check for external not being null
Although the code should never evaluate for null external
add explict check for analyzer.
| -rw-r--r-- | tools/vgsplit.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/vgsplit.c b/tools/vgsplit.c index 778e63d47..8a785bdbd 100644 --- a/tools/vgsplit.c +++ b/tools/vgsplit.c @@ -341,8 +341,9 @@ static int _move_thins(struct volume_group *vg_from, if ((_lv_is_in_vg(vg_to, data_lv) || _lv_is_in_vg(vg_to, seg->external_lv))) { - if (_lv_is_in_vg(vg_from, seg->external_lv) || - _lv_is_in_vg(vg_from, data_lv)) { + if (seg->external_lv && + (_lv_is_in_vg(vg_from, seg->external_lv) || + _lv_is_in_vg(vg_from, data_lv))) { log_error("Can't split external origin %s " "and pool %s between two Volume Groups.", display_lvname(seg->external_lv), |