diff options
| author | Peter Rajnoha <prajnoha@redhat.com> | 2022-08-05 11:02:25 +0200 |
|---|---|---|
| committer | Peter Rajnoha <prajnoha@redhat.com> | 2022-08-11 11:10:11 +0200 |
| commit | fc8fda641781d0978ff22ad0a59d5a19b5e450e1 (patch) | |
| tree | 917b77c03cc0fc4de1e181a1487e846d7076ada3 | |
| parent | b318c9c20f40be1583e7d0751a733f77be173012 (diff) | |
| download | lvm2-fc8fda641781d0978ff22ad0a59d5a19b5e450e1.tar.gz | |
report: fix pe_start column type from NUM to SIZ
The 'pe_start' column was incorrectly marked as being of type NUM.
This was not correct as pe_start is actually of type SIZ, which means
it can have a size suffix and hence it's not a pure numeric value.
Proper column type is important for selection to work correctly, so we
can also do comparisons while using suffixes.
This is also important for new "json_std" output format which does not
put double quotes around pure numeric values. With pe_start incorrectly
marked as NUM instead of SIZ, this produced invalid JSON output
like '"pe_start" = 1.00m' because it contained the 'm' (or other)
size suffix. If properly marked as SIZ, this is then put in double
quotes like '"pe_start" = "1.00m"'.
| -rw-r--r-- | lib/report/columns.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/report/columns.h b/lib/report/columns.h index 7e450dace..d702635d2 100644 --- a/lib/report/columns.h +++ b/lib/report/columns.h @@ -191,7 +191,7 @@ FIELD(LABEL, label, NUM, "PExtVsn", type, 0, pvextvsn, pv_ext_vsn, "PV header ex /* * PVS type fields */ -FIELD(PVS, pv, NUM, "1st PE", pe_start, 7, size64, pe_start, "Offset to the start of data on the underlying device.", 0) +FIELD(PVS, pv, SIZ, "1st PE", pe_start, 7, size64, pe_start, "Offset to the start of data on the underlying device.", 0) FIELD(PVS, pv, SIZ, "PSize", id, 0, pvsize, pv_size, "Size of PV in current units.", 0) FIELD(PVS, pv, SIZ, "PFree", id, 0, pvfree, pv_free, "Total amount of unallocated space in current units.", 0) FIELD(PVS, pv, SIZ, "Used", id, 0, pvused, pv_used, "Total amount of allocated space in current units.", 0) |