summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2016-02-22 10:49:45 +0100
committerZdenek Kabelac <zkabelac@redhat.com>2016-02-22 14:18:28 +0100
commitfba54ae55e888d290f8783d813bbecf3f1cfdd61 (patch)
treeed54db810cd829e028350e76555f61408f52cca5
parent275c9f7e7789124ba67533522e7b3a347f5a6f8f (diff)
downloadlvm2-fba54ae55e888d290f8783d813bbecf3f1cfdd61.tar.gz
cleanup: libdm clang warnings
Add some extra clang pointer validation so we do not try deref NULL.
-rw-r--r--libdm/libdm-stats.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/libdm/libdm-stats.c b/libdm/libdm-stats.c
index d32e4ea0a..1eeca0657 100644
--- a/libdm/libdm-stats.c
+++ b/libdm/libdm-stats.c
@@ -963,7 +963,9 @@ static void _stats_walk_next(const struct dm_stats *dms, int region,
if (!dms || !dms->regions)
return;
- cur = &dms->regions[*cur_r];
+ if (!(cur = &dms->regions[*cur_r]))
+ return;
+
present = _stats_region_present(cur);
if (region && present)
@@ -1314,7 +1316,7 @@ static int _dm_stats_populate_region(struct dm_stats *dms, uint64_t region_id,
if (!_stats_bound(dms))
return_0;
- if (!_stats_parse_region(dms, resp, region, region->timescale)) {
+ if (!region || !_stats_parse_region(dms, resp, region, region->timescale)) {
log_error("Could not parse @stats_print message response.");
return 0;
}