diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2015-11-25 16:04:27 +0100 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2015-11-26 09:27:37 +0100 |
| commit | 528695ec2004dcadaacba99d51685ac4a0582ea7 (patch) | |
| tree | 4726b7f7f2fcde2c91e356c5545a278fc88d06fa | |
| parent | d582be43d4cee8c74ee4e251d299a321ded474fa (diff) | |
| download | lvm2-528695ec2004dcadaacba99d51685ac4a0582ea7.tar.gz | |
cleanup: avoid allocation for vg_name
Since we do not use dev_manager in a way we would have destroyed VG
content while in-use - we could safely keep just pointer.
So dropping strdup.
Also it seems we actually no longer use vg_name for anything
so it may possibly go away completely unless it would be useful
for debugging...
| -rw-r--r-- | lib/activate/dev_manager.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c index eb47ed147..9110ecbe7 100644 --- a/lib/activate/dev_manager.c +++ b/lib/activate/dev_manager.c @@ -66,7 +66,7 @@ struct dev_manager { unsigned track_pending_delete; unsigned track_pvmove_deps; - char *vg_name; + const char *vg_name; }; struct lv_layer { @@ -1230,9 +1230,7 @@ struct dev_manager *dev_manager_create(struct cmd_context *cmd, dm->cmd = cmd; dm->mem = mem; - - if (!(dm->vg_name = dm_pool_strdup(dm->mem, vg_name))) - goto_bad; + dm->vg_name = vg_name; /* * When we manipulate (normally suspend/resume) the PVMOVE |