summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2014-04-17 10:05:56 +0200
committerZdenek Kabelac <zkabelac@redhat.com>2014-04-18 16:38:47 +0200
commit0e05e1cf6cb9323cc48ff38adc781f22a3c7d172 (patch)
treec75e8e3187c2c5eea072a05caab6e8eb75351b98
parent0b6d6bfb772f8320866e938ecba9894dc2d1cd7e (diff)
downloadlvm2-0e05e1cf6cb9323cc48ff38adc781f22a3c7d172.tar.gz
asprintf: fix test for error result
On error this function returns -1. Since the functions however do not propagate error upward, it's rather cleanup change.
-rw-r--r--lib/cache/lvmetad.c2
-rw-r--r--tools/pvscan.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/cache/lvmetad.c b/lib/cache/lvmetad.c
index c1eb4aa6e..d0c4a4d89 100644
--- a/lib/cache/lvmetad.c
+++ b/lib/cache/lvmetad.c
@@ -124,7 +124,7 @@ void lvmetad_set_token(const struct dm_config_value *filter)
filter = filter->next;
}
- if (!dm_asprintf(&_lvmetad_token, "filter:%u", ft))
+ if (dm_asprintf(&_lvmetad_token, "filter:%u", ft) < 0)
log_warn("WARNING: Failed to set lvmetad token. Out of memory?");
}
diff --git a/tools/pvscan.c b/tools/pvscan.c
index 4121c7b02..ac43295ab 100644
--- a/tools/pvscan.c
+++ b/tools/pvscan.c
@@ -166,7 +166,7 @@ static int _clear_dev_from_lvmetad_cache(dev_t devno, int32_t major, int32_t min
{
char *buf;
- if (!dm_asprintf(&buf, "%" PRIi32 ":%" PRIi32, major, minor))
+ if (dm_asprintf(&buf, "%" PRIi32 ":%" PRIi32, major, minor) < 0)
stack;
if (!lvmetad_pv_gone(devno, buf ? : "", handler)) {
dm_free(buf);