summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2020-09-25 22:42:22 +0200
committerZdenek Kabelac <zkabelac@redhat.com>2020-09-25 22:59:35 +0200
commit8b22e3808772601725c0e253f4aa5bed24905271 (patch)
treea3fedccff889e167f93c136b67669965f545ac62
parentef59c83f2df61b0f0263b0e32dac66eb0cb75488 (diff)
downloadlvm2-8b22e3808772601725c0e253f4aa5bed24905271.tar.gz
thin: improve error message
Add more info, explaing why the suspend of thin snapshot origin was omitted.
-rw-r--r--lib/thin/thin.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/lib/thin/thin.c b/lib/thin/thin.c
index d759b76e4..9c4bfb39c 100644
--- a/lib/thin/thin.c
+++ b/lib/thin/thin.c
@@ -361,8 +361,11 @@ static int _thin_pool_add_target_line(struct dev_manager *dm,
if (!lv_thin_pool_transaction_id(seg->lv, &transaction_id))
return_0; /* Thin pool should exist and work */
if ((transaction_id + 1) != seg->transaction_id) {
- log_error("Can't create snapshot %s as origin %s is not suspended.",
- lmsg->u.lv->name, origin->name);
+ log_error("Omitting suspend of thin snapshot origin %s with expected "
+ "transaction_id " FMTu64 ", but active pool has " FMTu64 ".",
+ display_lvname(origin),
+ !seg->transaction_id ? 0 : seg->transaction_id - 1,
+ transaction_id);
return 0;
}
}