diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2021-09-03 19:31:44 +0200 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2021-09-06 14:00:20 +0200 |
| commit | 52b56204764e421b693d94fa38834d71e29deced (patch) | |
| tree | 5e0c3567825234d04882defcb8e43a13d1c250fa | |
| parent | 1ae157a0f67e984ef3037d19d62b84a3b0201c84 (diff) | |
| download | lvm2-52b56204764e421b693d94fa38834d71e29deced.tar.gz | |
makefiles: sanitize environment
Compilation needs to generate 'C' locale sorted command file
definitions. To always enforce 'C' sorting rules user LC_ALL
instead of LANG, as LANG settings can be overuled by
other LC settings like LC_COLLATE and may result into miscompiled
lvm2 binary if locales ordering differs from 'C'.
Reported-by: jmp-lvm2@ookaze.fr
| -rw-r--r-- | tools/Makefile.in | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/Makefile.in b/tools/Makefile.in index ec546ca63..e0e180474 100644 --- a/tools/Makefile.in +++ b/tools/Makefile.in @@ -181,7 +181,7 @@ cmds.h: $(srcdir)/command-lines.in Makefile ( cat $(srcdir)/license.inc && \ echo "/* Do not edit. This file is generated by the Makefile. */" && \ echo "cmd(CMD_NONE, none)" && \ - $(GREP) '^ID:' $(srcdir)/command-lines.in | LANG=C $(SORT) -u | $(AWK) '{print "cmd(" $$2 "_CMD, " $$2 ")"}' && \ + $(GREP) '^ID:' $(srcdir)/command-lines.in | LC_ALL=C $(SORT) -u | $(AWK) '{print "cmd(" $$2 "_CMD, " $$2 ")"}' && \ echo "cmd(CMD_COUNT, count)" \ ) > $@ |