diff options
| author | Heinz Mauelshagen <heinzm@redhat.com> | 2015-01-07 13:25:08 +0100 |
|---|---|---|
| committer | Peter Rajnoha <prajnoha@redhat.com> | 2015-01-07 13:25:08 +0100 |
| commit | aaecbb181838102e1ce58ea19df14eb69db79dd9 (patch) | |
| tree | 7ca7b3e8f92fbb733edb20b0891d0d62af61559d | |
| parent | ff1eca3b6f1b40158fa5a5877b1ad6de72e4ed1e (diff) | |
| download | lvm2-aaecbb181838102e1ce58ea19df14eb69db79dd9.tar.gz | |
raid: fix mirror image naming when converting from mirror to raid1
$ lvcreate -l1 -m1 --type mirror vg
Logical volume "lvol0" created.
$ lvconvert --type raid1 vg/lvol0
Before:
$ lvs -a vg
LV VG Active Attr LSize Cpy%Sync Layout Role
lvol0 vg active rwi-a-r--- 4.00m 100.00 raid,raid1 public
[lvol0_mimage_0_rimage_0] vg active iwi-aor--- 4.00m linear private,raid,image
[lvol0_mimage_1_rimage_1] vg active iwi-aor--- 4.00m linear private,raid,image
[lvol0_rmeta_0] vg active ewi-aor--- 4.00m linear private,raid,metadata
[lvol0_rmeta_1] vg active ewi-aor--- 4.00m linear private,raid,metadata
Incorrect name: lvol0_mimage_0_rimage_0
With this patch applied:
$ lvs -a vg
LV VG Active Attr LSize Cpy%Sync Layout Role
lvol0 vg active rwi-a-r--- 4.00m 100.00 raid,raid1 public
[lvol0_rimage_0] vg active iwi-aor--- 4.00m linear private,raid,image
[lvol0_rimage_1] vg active iwi-aor--- 4.00m linear private,raid,image
[lvol0_rmeta_0] vg active ewi-aor--- 4.00m linear private,raid,metadata
[lvol0_rmeta_1] vg active ewi-aor--- 4.00m linear private,raid,metadata
Proper name: lvol0_rimage_0
| -rw-r--r-- | lib/metadata/raid_manip.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c index 59d3adb88..6f951f4b8 100644 --- a/lib/metadata/raid_manip.c +++ b/lib/metadata/raid_manip.c @@ -1409,7 +1409,7 @@ static int _convert_mirror_to_raid1(struct logical_volume *lv, } for (s = 0; s < seg->area_count; ++s) { - if (!(new_name = _generate_raid_name(seg_lv(seg, s), "rimage", s))) + if (!(new_name = _generate_raid_name(lv, "rimage", s))) return_0; log_debug_metadata("Renaming %s to %s", seg_lv(seg, s)->name, new_name); seg_lv(seg, s)->name = new_name; |