clean: avoid cleaning iterator on error path

Return error dirrectly instead of using 'out' code path.

1 files changed, 2 insertions, 2 deletions

diff --git a/tools/toollib.c b/tools/toollib.c
index b35283916..8e882e926 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -3933,14 +3933,14 @@ static int _get_all_devices(struct cmd_context *cmd,
 
 			if (!(dil = dm_pool_alloc(cmd->mem, sizeof(*dil)))) {
 				log_error("device_id_list alloc failed.");
-				goto out;
+				return ECMD_FAILED;
 			}
 
 			strncpy(dil->pvid, hint->pvid, ID_LEN);
 			dil->dev = dev;
 			dm_list_add(all_devices, &dil->list);
 		}
-		return 1;
+		return ECMD_PROCESSED;
 	}
 
 	log_debug("Getting list of all devices from system");