diff options
author | Zdenek Kabelac <zkabelac@redhat.com> | 2019-06-25 15:29:26 +0200 |
---|---|---|
committer | Zdenek Kabelac <zkabelac@redhat.com> | 2019-06-25 17:34:18 +0200 |
commit | ff2bf113604882a0f21f118a5bb16076399bb67a (patch) | |
tree | a358f4c5f11a8626d0701d80e4d99bff31fa6c75 | |
parent | 7232458b6c114cc83b471f08abc49fd1673831c4 (diff) | |
download | lvm2-ff2bf113604882a0f21f118a5bb16076399bb67a.tar.gz |
cov: ensure cname exists before derefering it
Just make it clear to analyzers cname can't be NULL.
TODO: maybe exclude NULL at front of the function...
-rw-r--r-- | tools/command.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/command.c b/tools/command.c index 377d03f0f..523753250 100644 --- a/tools/command.c +++ b/tools/command.c @@ -1916,7 +1916,7 @@ void print_usage(struct command *cmd, int longhelp, int desc_first) * see print_common_options_cmd() */ - if ((cname->variants > 1) && cname->common_options[opt_enum]) + if (cname && (cname->variants > 1) && cname->common_options[opt_enum]) continue; printf("\n\t["); @@ -1956,7 +1956,7 @@ void print_usage(struct command *cmd, int longhelp, int desc_first) * see print_common_options_cmd() */ - if ((cname->variants > 1) && cname->common_options[opt_enum]) + if (cname && (cname->variants > 1) && cname->common_options[opt_enum]) continue; printf("\n\t["); @@ -3384,7 +3384,7 @@ static int _print_man(char *name, char *des_file, int secondary) if (!prev_cmd || strcmp(prev_cmd->name, cmd->name)) { printf(".SH NAME\n"); - if (cname->desc) + if (cname && cname->desc) printf("%s - %s\n", lvmname, cname->desc); else printf("%s\n", lvmname); |