diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2021-10-15 14:48:48 +0200 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2021-10-15 23:40:56 +0200 |
| commit | 882141eb8c1a9718652cd903e411b6876aff54ef (patch) | |
| tree | f5a94b57207f56a305ea9f60041da128fad54782 | |
| parent | 65ba4964df27d2d3f308d2f378e814290ba6d7bb (diff) | |
| download | lvm2-882141eb8c1a9718652cd903e411b6876aff54ef.tar.gz | |
cov: check pointer before dereferencing
Check pv2 is non-null before trying to deref its tags.
| -rw-r--r-- | lib/metadata/lv_manip.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c index 1a4e613a7..003748d6f 100644 --- a/lib/metadata/lv_manip.c +++ b/lib/metadata/lv_manip.c @@ -2354,7 +2354,7 @@ static int _match_pv_tags(const struct dm_config_node *cling_tag_list_cn, const struct dm_config_value *cv; const char *str; const char *tag_matched; - struct dm_list *tags_to_match = mem ? NULL : pv_tags ? : &pv2->tags; + struct dm_list *tags_to_match = mem ? NULL : pv_tags ? : ((pv2) ? &pv2->tags : NULL); struct dm_str_list *sl; unsigned first_tag = 1; @@ -2409,7 +2409,7 @@ static int _match_pv_tags(const struct dm_config_node *cling_tag_list_cn, continue; } - if (!str_list_match_list(&pv1->tags, tags_to_match, &tag_matched)) + if (tags_to_match && !str_list_match_list(&pv1->tags, tags_to_match, &tag_matched)) continue; if (!pv_tags) { |