summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOndrej Kozina <okozina@redhat.com>2015-05-04 14:32:32 +0200
committerOndrej Kozina <okozina@redhat.com>2015-05-04 16:56:28 +0200
commit079895b8bee452c36bf1952df7e40d508ff299eb (patch)
tree2ac63f1f2a37211517f50ab8153d739a43bec333
parent7a5a4f952e567ebb32e61414db62292eab81b6c7 (diff)
downloadlvm2-079895b8bee452c36bf1952df7e40d508ff299eb.tar.gz
polldaemon: move lvconvert_get_copy_vg code
Moving lvconvert_get_copy_vg to polldaemon (poll_get_copy_vg). Clear move and rename.
-rw-r--r--tools/lvconvert.c8
-rw-r--r--tools/lvconvert_poll.c14
-rw-r--r--tools/lvconvert_poll.h4
-rw-r--r--tools/polldaemon.c13
-rw-r--r--tools/polldaemon.h5
5 files changed, 21 insertions, 23 deletions
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index 732f6fdd6..4d8d08c8c 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -700,21 +700,21 @@ static int _read_params(struct cmd_context *cmd, int argc, char **argv,
}
static struct poll_functions _lvconvert_mirror_fns = {
- .get_copy_vg = lvconvert_get_copy_vg,
+ .get_copy_vg = poll_get_copy_vg,
.get_copy_lv = lvconvert_get_copy_lv,
.poll_progress = poll_mirror_progress,
.finish_copy = lvconvert_mirror_finish,
};
static struct poll_functions _lvconvert_merge_fns = {
- .get_copy_vg = lvconvert_get_copy_vg,
+ .get_copy_vg = poll_get_copy_vg,
.get_copy_lv = lvconvert_get_copy_lv,
.poll_progress = poll_merge_progress,
.finish_copy = lvconvert_merge_finish,
};
static struct poll_functions _lvconvert_thin_merge_fns = {
- .get_copy_vg = lvconvert_get_copy_vg,
+ .get_copy_vg = poll_get_copy_vg,
.get_copy_lv = lvconvert_get_copy_lv,
.poll_progress = poll_thin_merge_progress,
.finish_copy = lvconvert_merge_finish,
@@ -3219,7 +3219,7 @@ static struct logical_volume *get_vg_lock_and_logical_volume(struct cmd_context
struct volume_group *vg;
struct logical_volume* lv = NULL;
- vg = lvconvert_get_copy_vg(cmd, vg_name, NULL);
+ vg = poll_get_copy_vg(cmd, vg_name, NULL);
if (vg_read_error(vg)) {
release_vg(vg);
return_NULL;
diff --git a/tools/lvconvert_poll.c b/tools/lvconvert_poll.c
index 4745d0645..b6ee980b3 100644
--- a/tools/lvconvert_poll.c
+++ b/tools/lvconvert_poll.c
@@ -16,20 +16,6 @@
#include "lvconvert_poll.h"
#include "tools.h"
-struct volume_group *lvconvert_get_copy_vg(struct cmd_context *cmd,
- const char *name,
- const char *uuid __attribute__((unused)))
-{
- dev_close_all();
-
- if (name && !strchr(name, '/'))
- return vg_read_for_update(cmd, name, NULL, 0);
-
- /* 'name' is the full LV name; must extract_vgname() */
- return vg_read_for_update(cmd, extract_vgname(cmd, name),
- NULL, 0);
-}
-
struct logical_volume *lvconvert_get_copy_lv(struct cmd_context *cmd __attribute__((unused)),
struct volume_group *vg,
const char *name,
diff --git a/tools/lvconvert_poll.h b/tools/lvconvert_poll.h
index d79962c05..801633e9f 100644
--- a/tools/lvconvert_poll.h
+++ b/tools/lvconvert_poll.h
@@ -21,10 +21,6 @@ struct cmd_context;
struct logical_volume;
struct volume_group;
-struct volume_group *lvconvert_get_copy_vg(struct cmd_context *cmd,
- const char *name,
- const char *uuid __attribute__((unused)));
-
struct logical_volume *lvconvert_get_copy_lv(struct cmd_context *cmd __attribute__((unused)),
struct volume_group *vg,
const char *name,
diff --git a/tools/polldaemon.c b/tools/polldaemon.c
index 2684f6358..b78e36435 100644
--- a/tools/polldaemon.c
+++ b/tools/polldaemon.c
@@ -49,6 +49,19 @@ progress_t poll_mirror_progress(struct cmd_context *cmd,
return PROGRESS_FINISHED_SEGMENT;
}
+struct volume_group *poll_get_copy_vg(struct cmd_context *cmd,
+ const char *name,
+ const char *uuid __attribute__((unused)))
+{
+ dev_close_all();
+
+ if (name && !strchr(name, '/'))
+ return vg_read_for_update(cmd, name, NULL, 0);
+
+ /* 'name' is the full LV name; must extract_vgname() */
+ return vg_read_for_update(cmd, extract_vgname(cmd, name), NULL, 0);
+}
+
static int _check_lv_status(struct cmd_context *cmd,
struct volume_group *vg,
struct logical_volume *lv,
diff --git a/tools/polldaemon.h b/tools/polldaemon.h
index 89c3aaee2..b602a0886 100644
--- a/tools/polldaemon.h
+++ b/tools/polldaemon.h
@@ -1,6 +1,6 @@
/*
* Copyright (C) 2003-2004 Sistina Software, Inc. All rights reserved.
- * Copyright (C) 2004 Red Hat, Inc. All rights reserved.
+ * Copyright (C) 2004-2015 Red Hat, Inc. All rights reserved.
*
* This file is part of LVM2.
*
@@ -72,4 +72,7 @@ progress_t poll_mirror_progress(struct cmd_context *cmd,
struct logical_volume *lv, const char *name,
struct daemon_parms *parms);
+struct volume_group *poll_get_copy_vg(struct cmd_context *cmd, const char *name,
+ const char *uuid);
+
#endif