diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2018-10-15 14:12:18 +0200 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2018-10-15 14:24:28 +0200 |
| commit | 5811fa33bbdb2065966489f334ba9fb1174369ca (patch) | |
| tree | a0d4b839aa39c99a1127402a5a9cf1d9cf95c9d0 | |
| parent | 954b885a08a733308e1117f166d41f4443cd13c3 (diff) | |
| download | lvm2-5811fa33bbdb2065966489f334ba9fb1174369ca.tar.gz | |
cov: missed return value test
Check validity of read.
| -rw-r--r-- | lib/format_text/format-text.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/format_text/format-text.c b/lib/format_text/format-text.c index 9634e47b9..99945b1ad 100644 --- a/lib/format_text/format-text.c +++ b/lib/format_text/format-text.c @@ -466,7 +466,8 @@ static struct raw_locn *_read_metadata_location_vg(struct device_area *dev_area, */ memset(vgnamebuf, 0, sizeof(vgnamebuf)); - dev_read_bytes(dev_area->dev, dev_area->start + rlocn->offset, NAME_LEN, vgnamebuf); + if (!dev_read_bytes(dev_area->dev, dev_area->start + rlocn->offset, NAME_LEN, vgnamebuf)) + return_NULL; if (!strncmp(vgnamebuf, vgname, len = strlen(vgname)) && (isspace(vgnamebuf[len]) || vgnamebuf[len] == '{')) @@ -1469,7 +1470,8 @@ int read_metadata_location_summary(const struct format_type *fmt, return 0; } - dev_read_bytes(dev_area->dev, dev_area->start + rlocn->offset, NAME_LEN, buf); + if (!dev_read_bytes(dev_area->dev, dev_area->start + rlocn->offset, NAME_LEN, buf)) + return_0; while (buf[len] && !isspace(buf[len]) && buf[len] != '{' && len < (NAME_LEN - 1)) |