summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBryn M. Reeves <bmr@redhat.com>2017-03-13 11:09:11 +0000
committerBryn M. Reeves <bmr@redhat.com>2017-03-13 11:09:11 +0000
commit9b0aba5fe9e6b22b85d7f6ff9f8fdef09db61bce (patch)
tree0e73cb90a301cf82c554bf486e0c8b1a76fba1ec
parent66760f9673659f0b3d52e9d7013bc69147101d9b (diff)
downloadlvm2-9b0aba5fe9e6b22b85d7f6ff9f8fdef09db61bce.tar.gz
dmfilemapd: return error for wrong number of args
The initial check on argc incorrectly returns 1 when the wrong number of arguments are present, causing a segfault in main() when no arguments are given: # dmfilemapd Wrong number of arguments. usage: dmfilemapd <fd> <group_id> <path> <mode> [<foreground>[<log_level>]] Segmentation fault (core dumped)
-rw-r--r--daemons/dmfilemapd/dmfilemapd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/daemons/dmfilemapd/dmfilemapd.c b/daemons/dmfilemapd/dmfilemapd.c
index 6d7c09f3e..4f2046695 100644
--- a/daemons/dmfilemapd/dmfilemapd.c
+++ b/daemons/dmfilemapd/dmfilemapd.c
@@ -255,7 +255,7 @@ static int _parse_args(int argc, char **argv, struct filemap_monitor *fm)
if (argc < 5) {
_early_log("Wrong number of arguments.");
_early_log("usage: %s", _usage);
- return 1;
+ return 0;
}
memset(fm, 0, sizeof(*fm));