summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2015-06-19 13:40:17 -0500
committerDavid Teigland <teigland@redhat.com>2015-06-23 17:08:54 -0500
commitdf822ab9c0ac41d8c7c2f06e7dab925962b8fa69 (patch)
tree332cf4938cf67a57c2fb191d1170c159db8bdcf7
parentdee2756e80bde999f83f855241abba4a69a0066d (diff)
downloadlvm2-df822ab9c0ac41d8c7c2f06e7dab925962b8fa69.tar.gz
lvmlockd: add fixme for an enhancement to add
-rw-r--r--daemons/lvmlockd/lvmlockd-core.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/daemons/lvmlockd/lvmlockd-core.c b/daemons/lvmlockd/lvmlockd-core.c
index 12a24bbbe..ade0aac70 100644
--- a/daemons/lvmlockd/lvmlockd-core.c
+++ b/daemons/lvmlockd/lvmlockd-core.c
@@ -3326,6 +3326,12 @@ static void client_send_result(struct client *cl, struct action *act)
* or if lockspaces exist, but not one with the global lock.
* Given this detail, it may be able to procede without
* the lock.
+ *
+ * FIXME: it would also help the caller to know if there
+ * are other sanlock VGs that have not been started.
+ * If there are, then one of them might have a global
+ * lock enabled. In that case, vgcreate may not want
+ * to create a new sanlock vg with gl enabled.
*/
pthread_mutex_lock(&lockspaces_mutex);
if (list_empty(&lockspaces))