diff options
author | Zdenek Kabelac <zkabelac@redhat.com> | 2015-11-13 11:05:00 +0100 |
---|---|---|
committer | Zdenek Kabelac <zkabelac@redhat.com> | 2015-11-13 11:17:06 +0100 |
commit | 6dadebb1e45b0adc63380b5c61fb37f6d7ffee5a (patch) | |
tree | ac14f580351c22b1d146f9ebb5bd3d6baf196777 | |
parent | 1f2a42c7b79ff99b29a999f0b636f340e5355456 (diff) | |
download | lvm2-6dadebb1e45b0adc63380b5c61fb37f6d7ffee5a.tar.gz |
cleanup: better error message
Use display_lvname.
-rw-r--r-- | tools/lvconvert.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/tools/lvconvert.c b/tools/lvconvert.c index 9fc064bf6..335f6a441 100644 --- a/tools/lvconvert.c +++ b/tools/lvconvert.c @@ -2246,19 +2246,20 @@ static int _lvconvert_merge_thin_snapshot(struct cmd_context *cmd, /* Check if merge is possible */ if (lv_is_merging_origin(origin)) { log_error("Snapshot %s is already merging into the origin.", - find_snapshot(origin)->lv->name); + display_lvname(find_snapshot(origin)->lv)); return 0; } if (lv_is_external_origin(origin)) { - log_error("\"%s\" is read-only external origin \"%s\".", - lv->name, origin_from_cow(lv)->name); + origin = origin_from_cow(lv); + log_error("%s is read-only external origin %s.", + display_lvname(lv), display_lvname(origin)); return 0; } if (lv_is_origin(origin)) { log_error("Merging into the old snapshot origin %s is not supported.", - origin->name); + display_lvname(origin)); return 0; } @@ -2288,7 +2289,8 @@ static int _lvconvert_merge_thin_snapshot(struct cmd_context *cmd, goto_out; if (origin_is_active && !activate_lv(cmd, lv)) { - log_error("Failed to reactivate origin %s.", lv->name); + log_error("Failed to reactivate origin %s.", + display_lvname(lv)); goto out; } |