diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2016-07-12 16:43:12 +0200 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2016-07-13 21:52:14 +0200 |
| commit | 4e1bf7acd39e2e6686f634be29b2c64a0aab705c (patch) | |
| tree | ca4483552b6ee7f7e2f4b1ac869ffff7e5dca1b1 | |
| parent | 4661c6b6fb7adc01a3fd42b5e802051b92d15d9d (diff) | |
| download | lvm2-4e1bf7acd39e2e6686f634be29b2c64a0aab705c.tar.gz | |
coverity: add some tests for function results
Even though they cannot normally happen...
| -rw-r--r-- | daemons/lvmetad/lvmetad-core.c | 2 | ||||
| -rw-r--r-- | lib/metadata/metadata.c | 6 |
2 files changed, 5 insertions, 3 deletions
diff --git a/daemons/lvmetad/lvmetad-core.c b/daemons/lvmetad/lvmetad-core.c index 31d093358..c4c1d68a6 100644 --- a/daemons/lvmetad/lvmetad-core.c +++ b/daemons/lvmetad/lvmetad-core.c @@ -861,7 +861,7 @@ static int remove_metadata(lvmetad_state *s, const char *vgid, int update_pvids) /* update_pvid_to_vgid will clear/free the pvid_to_vgid hash */ if (update_pvids && meta_lookup) - _update_pvid_to_vgid(s, meta_lookup, "#orphan", 0); + (void) _update_pvid_to_vgid(s, meta_lookup, "#orphan", 0); /* free the unmapped data */ diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c index d8bb72627..8a9a1b2f7 100644 --- a/lib/metadata/metadata.c +++ b/lib/metadata/metadata.c @@ -4641,7 +4641,8 @@ static int _check_devs_used_correspond_with_lv(struct dm_pool *mem, struct dm_li dev = dl->dev; if (!(dev->flags & DEV_ASSUMED_FOR_LV)) { if (!found_inconsistent) { - dm_pool_begin_object(mem, 32); + if (!dm_pool_begin_object(mem, 32)) + return_0; found_inconsistent = 1; } else { if (!dm_pool_grow_object(mem, DEV_LIST_DELIM, sizeof(DEV_LIST_DELIM) - 1)) @@ -4674,7 +4675,8 @@ static int _check_devs_used_correspond_with_lv(struct dm_pool *mem, struct dm_li } if (!(dev->flags & DEV_USED_FOR_LV)) { if (!found_inconsistent) { - dm_pool_begin_object(mem, 32); + if (!dm_pool_begin_object(mem, 32)) + return_0; found_inconsistent = 1; } else { if (!dm_pool_grow_object(mem, DEV_LIST_DELIM, sizeof(DEV_LIST_DELIM) - 1)) |